/activity

Use automatic dependency injection #33

Merged
merged 18 commits into from Aug 29, 2016
+181 −292

Labels

3. to review bug

Milestone

  Nextcloud 11.0

Assignees

No one assigned

2 participants

@nickvergessen @rullzer
@nickvergessen
Nextcloud member
nickvergessen commented Aug 26, 2016

@rullzer want to review some clean up?

Only thing left is the worst class of this app OCA\Activity\FilesHooks which needs some further examination.

nickvergessen added some commits Aug 26, 2016
@nickvergessen nickvergessen Use automatic DI for Data class
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
7d6b335
@nickvergessen nickvergessen Use automatic DI for UserSettings class
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
fa67834
@nickvergessen nickvergessen Use automatic DI for Consumer class
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
fc85db6
@nickvergessen nickvergessen Use automatic DI for DataHelper class
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
c10a20f
@nickvergessen nickvergessen Use automatic DI for MailQueueHandler class
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
ffb8ed2
@nickvergessen nickvergessen Use an alias for EndPointController
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
69c73d3
@nickvergessen nickvergessen Add namespace to Navigation service as preparation for automatic DI
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
537da56
@nickvergessen nickvergessen Add namespace to Hooks service as preparation for automatic DI
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
6fd2318
@nickvergessen nickvergessen Add namespace to GroupHelper service as preparation for automatic DI
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
410a74d
@nickvergessen nickvergessen Make GroupHelperSingleEntries an injectable service
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
8257b83
@nickvergessen nickvergessen Use an alias for ActivitiesController
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
8359ce2
@nickvergessen nickvergessen Use automatic DI for ViewInfoCache class
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
5c625c6
@nickvergessen nickvergessen Use automatic DI for OCSEndPoint class
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
ee58814
@nickvergessen nickvergessen Replace more usages of the View with DI
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
e06e2c3
@nickvergessen nickvergessen Use an alias for FeedController
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
12ce84a
@nickvergessen nickvergessen Use an alias for SettingsController
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
a35db06
@nickvergessen nickvergessen Use automatic DI for the Factory class
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
5f51e42
@nickvergessen nickvergessen Use automatic DI for the Navigation class
This commit was signed with a verified signature.
@nickvergessen nickvergessen Joas Schilling
GPG key ID: E166FD8976B3BAC8 Learn about signing commits
72e24fc
@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Aug 26, 2016
@rullzer
Nextcloud member
rullzer commented Aug 28, 2016

LGTM! 🎉

@nickvergessen nickvergessen merged commit 61db8db into master Aug 29, 2016
1 check passed

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
@nickvergessen nickvergessen deleted the automatic-dependency-injection branch Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment