[x86/Linux] Enable FEATURE_ARRAYSTUB_AS_IL #9752

Merged

jkotas merged 2 commits into dotnet:master from parjong:fix/x86_ARRAYSTUB_AS_IL

Feb 24, 2017

+9 −6

Contributor

parjong commented

This commit enables FEATURE_ARRAYSTUB_AS_IL for x86/Linux to fix #9687.

parjong

[x86/Linux] Enable FEATURE_ARRAYSTUB_AS_IL

8d6c467

dnfclas added the cla-already-signed label

Contributor

parjong commented

This PR addresses the incorrect unwind issue discussed in #9688.

jkotas reviewed

clr.coreclr.props

            
    @@ -83,6 +83,7 @@
  
       </PropertyGroup>

       <PropertyGroup Condition="'$(TargetsUnix)' != 'true'">

    +    <FeatureArrayStubAsIL Condition="('$(TargetArch)' == 'arm') or ('$(TargetArch)' == 'amd64') or ('$(TargetArch)' == 'arm64')">true</FeatureArrayStubAsIL>

jkotas

• edited Member

Nit: I would be nice to move FeatureStubsAsIL from the common block to here as well.

parjong

Contributor

@jkotas Thanks you for comment! It would be much better. 7ec9019 revised PR as you suggested.

jkotas approved these changes

parjong

Move FeatureStubsAsIL into Windows-specific block

7ec9019

Contributor

parjong commented

@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test please

jkotas merged commit 70b21c8 into dotnet:master

13 checks passed

13 checks passed

CentOS7.1 x64 Debug Build and Test Build finished.

Details

FreeBSD x64 Checked Build Build finished.

Details

Linux ARM Emulator Cross Debug Build Build finished.

Details

Linux ARM Emulator Cross Release Build Build finished.

Details

OSX x64 Checked Build and Test Build finished.

Details

Ubuntu x64 Checked Build and Test Build finished.

Details

Ubuntu x64 Formatting Build finished.

Details

Windows_NT arm Cross Debug Build Build finished.

Details

Windows_NT arm Cross Release Build Build finished.

Details

Windows_NT x64 Debug Build and Test Build finished.

Details

Windows_NT x64 Formatting Build finished.

Details

Windows_NT x64 Release Priority 1 Build and Test Build finished.

Details

Windows_NT x86 Checked Build and Test Build finished.

Details

parjong deleted the parjong:fix/x86_ARRAYSTUB_AS_IL branch

parjong referenced this pull request

Merged

[x86/Linux] Clean up ARRAY STUB(s) #9811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can't perform that action at this time.