/wp-calypso

Happychat: Changes happychat title and label messaging #10940

Merged
merged 3 commits into from Jan 27, 2017
+3 −3

Reviewers

@a8ci18n a8ci18n

@mkaz mkaz

@kriskarkoski kriskarkoski

Assignees

@beaucollins beaucollins

Labels

Happychat

Projects

None yet

Milestone

No milestone

5 participants

@beaucollins @matticbot @kriskarkoski @mkaz @a8ci18n
@beaucollins
Contributor
beaucollins commented Jan 25, 2017 • edited

Fixes #10768 and #10767
@beaucollins beaucollins Happychat: Changes happychat title to 'Support Chat'
This commit was signed with a verified signature.
@beaucollins beaucollins Robert “Beau” Collins
GPG key ID: 6B694E68E67B9CE1 Learn about signing commits

All checks have passed

2 successful checks
ci/circleci — Your tests passed on CircleCI!
Details
@a8ci18n
ci/i18n — Total: 1 string. Translations: 100% coverage.
Details
58af2e1
@matticbot
matticbot commented Jan 25, 2017

Test live: https://calypso.live/?branch=fix/happychat-title
@beaucollins beaucollins requested a review from kriskarkoski Jan 25, 2017
beaucollins added some commits Jan 25, 2017
@beaucollins beaucollins Changes happychat text prompt 
Fixes #10767
This commit was signed with a verified signature.
@beaucollins beaucollins Robert “Beau” Collins
GPG key ID: 6B694E68E67B9CE1 Learn about signing commits
c495d8c
@beaucollins beaucollins Fixes code style whitespace issue
This commit was signed with a verified signature.
@beaucollins beaucollins Robert “Beau” Collins
GPG key ID: 6B694E68E67B9CE1 Learn about signing commits

All checks have passed

2 successful checks
ci/circleci — Your tests passed on CircleCI!
Details
@a8ci18n
ci/i18n — Total: 2 strings (1 new). Translations: 50% coverage.
Details
bd01550
@beaucollins beaucollins self-assigned this Jan 25, 2017
@beaucollins beaucollins changed the title from Happychat: Changes happychat title to 'Support Chat' to Happychat: Changes happychat title and label messaging Jan 25, 2017
client/components/happychat/composer.jsx
@@ -49,14 +49,14 @@ export const Composer = React.createClass( {
ref={ this.setScrollbleedTarget }
onFocus={ onFocus }
type="text"
- placeholder={ translate( 'Ask a question...' ) }
+ placeholder={ translate( 'Type a message …' ) }
@a8ci18n
a8ci18n Jan 25, 2017

Alternate string suggestion:

  • translate( 'Unknown message type passed' )— translations: 9.

PR translation status page

@kriskarkoski
kriskarkoski commented Jan 26, 2017

This tested perfectly for me:

screen shot 2017-01-26 at 3 59 15 pm
@mkaz
mkaz approved these changes Jan 27, 2017 View changes

Easy enough updating of text / labels
👍

client/components/happychat/composer.jsx
onChange={ onChange }
onKeyDown={ onKeyDown }
value={ message } />
</div>
<button className="happychat__submit"
onClick={ sendMessage }>
- <svg viewBox="0 0 24 24" width="24" height="24"><path d="M2 21l21-9L2 3v7l15 2-15 2z"/></svg>
+ <svg viewBox="0 0 24 24" width="24" height="24"><path d="M2 21l21-9L2 3v7l15 2-15 2z" /></svg>
@beaucollins
beaucollins Jan 27, 2017 Contributor

fix for eslint warning react/jsx-space-before-closing

@beaucollins beaucollins merged commit bc4d9b9 into master Jan 27, 2017
2 checks passed

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
ci/i18n Total: 2 strings (1 new). Translations: 50% coverage.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment