/wp-calypso

SSR: Remove two obsolete mocks #10906

Merged
merged 1 commit into from Jan 25, 2017
+0 −2

Reviewers

@seear seear

Assignees

@ockham ockham

Labels

Server Side Rendering Themes

Projects

None yet

Milestone

No milestone

3 participants

@ockham @matticbot @seear
@ockham
Contributor
ockham commented Jan 24, 2017

These were breaking because they use Popover -- but that's now being mocked too, so no reason to still mock the consumer components.

To test:

  • Restart Calypso. Verify that it runs, and check that the logged-out theme showcase looks sane ( /design)
  • Verify that unit tests pass. (Just check CircleCI 😄 )
@ockham ockham SSR: Remove two obsolete mocks

All checks have passed

2 successful checks
ci/circleci — Your tests passed on CircleCI!
Details
@a8ci18n
ci/i18n — 0 new strings. ¡Ándale!
Details
dd80620
@ockham ockham self-assigned this Jan 24, 2017
@ockham ockham requested a review from seear Jan 24, 2017
@matticbot
matticbot commented Jan 24, 2017

Test live: https://calypso.live/?branch=remove/two-obsolete-ssr-mocks
@seear
seear approved these changes Jan 25, 2017 View changes

Works good 🚢

webpack.config.node.js
@@ -106,7 +106,6 @@ var webpackConfig = {
new webpack.NormalModuleReplacementPlugin( /^lib\/post-normalizer\/rule-create-better-excerpt$/, 'lodash/noop' ), // Depends on BOM
new webpack.NormalModuleReplacementPlugin( /^components\/seo\/preview-upgrade-nudge$/, 'components/empty-component' ), // Depends on page.js and should never be required server side
new webpack.NormalModuleReplacementPlugin( /^components\/popover$/, 'components/empty-component' ), // Depends on BOM and interactions don't work without JS
- new webpack.NormalModuleReplacementPlugin( /^my-sites\/themes\/thanks-modal$/, 'components/empty-component' ), // Depends on BOM
@seear
seear Jan 25, 2017 Member

This can probably come out of the desktop config as well.

@ockham
ockham Jan 25, 2017 Contributor

Ah, good catch. I'll file a PR.

@ockham
ockham Jan 25, 2017 Contributor

Automattic/wp-desktop#260

@ockham ockham merged commit 5934fd5 into master Jan 25, 2017
2 checks passed

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
ci/i18n 0 new strings. ¡Ándale!
Details
@ockham ockham deleted the remove/two-obsolete-ssr-mocks branch Jan 25, 2017
@ockham ockham referenced this pull request in Automattic/wp-desktop Jan 25, 2017
Open

Webpack Config: Remove obsolete stub #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment