-
Ignore home config from disableWhenNoEslintConfig (#778)
* Ignore home config from disableWhenNoEslintConfig * Move isConfigAtHomeRoot to its own file It needs to be used in both worker and non-worker, so itβs easiest to just put it in its own file for now until we re-structure. * Extract copyFileToTempDir as test helper function * Move temp dir creation to `copyFileToTempDir`
-
Determine fix results based on exit code (#777)
* Determine fix results based on exit code Perhaps in the past ESLint threw an error if `--fix` did not fix all of the errors in a file. Or, maybe this logic was flawed from the start. Either way, this change just looks at the exit code (`0` if there are no linting errors left, `1` if there are), and returns an appropriate string. Both cases are really success messages, there were no errors. If there was an error for some reason, we need to print the `err.message` string, because `addWarning` expects a string, not an error object. * Do not attempt to fix on save when disabled If `disableWhenNoEslintConfig` is disabling linting, we should also not be trying to perform an autofix. * Observe disableWhenNoEslintConfig config
-
Update dependencies to enable Greenkeeper
π΄ (#769)* chore(package): update dependencies https://greenkeeper.io/ * Update peerDependencies Update to the following to satisfy the peerDependencies: * `eslint@^3.12.0` * `eslint-plugin-import@^2.2.0`
-
Merge pull request #762 from AtomLinter/arcanemagus/update-transcoding
Move to babel-cli
-
Replace the current `ucompiler` setup with a standard `babel-cli` setup, along with a configuration that transpiles _only_ what is necessary, instead of the current method of transpiling everything that _might_ be needed. This currently transpiles to support for Node.js v5 as that is what Atom v1.10.0 ships with, which is our current minimum version.
This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 4414384AEEE3FB2B Learn about signing commits -
Merge pull request #761 from AtomLinter/arcanemagus/graceful-invalid-β¦
β¦point Gracefully handle invalid points
-
If the error doesn't look like one from rangeFromLineNumber, then just re-throw it.
This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 4414384AEEE3FB2B Learn about signing commits -
Document processESLintMessages
Arcanemagus committedDec 6, 2016 This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 4414384AEEE3FB2B Learn about signing commits -
Rename processMessages to processESLintMessages
Arcanemagus committedDec 6, 2016 This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 4414384AEEE3FB2B Learn about signing commits -
Note position index conversion
Provide a note in the code as to why the points are all having 1 subtracted from them.
Arcanemagus committedDec 6, 2016 This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 4414384AEEE3FB2B Learn about signing commits
-
Correct the specs for the updated debug text.
This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 15320D3C4A506996 Learn about signing commits -
Escape rule name in generated issue
Make the rule name in the generated issue show as code instead of raw text.
This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 15320D3C4A506996 Learn about signing commits -
The worker wasn't being passed into the call to `getDebugInfo()` properly.
Arcanemagus committedDec 1, 2016 This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 15320D3C4A506996 Learn about signing commits -
Move invalid point trace generation to a function
The generation of the trace messages doesn't need to be in the main message processing.
This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 15320D3C4A506996 Learn about signing commits -
Move message processing to a helper function
Move processing of messages to a helper function so the code isn't as complex in the main program.
This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 15320D3C4A506996 Learn about signing commits -
Convert invalid points to Linter messages
Instead of throwing errors, trap the message and create a Linter message telling the user that something went wrong. Include a link to report the problem including all the debug information.
Arcanemagus committedDec 1, 2016 This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 4414384AEEE3FB2B Learn about signing commits -
Move debug string generation to helper
Move the generation of the debug string to a helper function as we will be using to also generate debug information when creating an issue.
Arcanemagus committedNov 21, 2016
-
Update eslint-config-airbnb-base to the latest version
π (#745)* chore(package): update eslint-config-airbnb-base to version 10.0.0 https://greenkeeper.io/ * Update peerDependencies Update the minimum dev versions to: * [email protected] * [email protected] * Cleanup ESLint config a little bit Just removing some sections that are duplicated in `eslint-config-airbnb-base`.
-
Update dependencies to enable Greenkeeper
π΄ (#744)* chore(package): update dependencies https://greenkeeper.io/ * Update ESLint to v3.8.0 Minimum version to satisfy the peerDependency of `[email protected]`.
-
Merge pull request #742 from AtomLinter/issue-template
Add issue template
-
-
Merge pull request #734 from AtomLinter/add-eslint-dev
Add ESLint to the devDependencies
-
Add ESLint to the devDependencies
As ESLint is not only a dependency of this project, but also used for developing it, it should have been listed in here from the start. Brought to the forefront by atom/ci#60 as we discovered that linting wasn't actually running on the CI builds.
This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 4414384AEEE3FB2B Learn about signing commits
-
This commit was signed with a verified signature.
Arcanemagus Landon Abney
GPG key ID: 4414384AEEE3FB2B Learn about signing commits -
Add support for endLine and endColumn (#709)
* Add support for endLine and endColumn Add support for creating a full range from an ESLint message if it specifies an `endLine` and `endColumn`. Also adds a `validatePoint` helper function to check that these coordinates given from ESLint are valid since we no longer have the checking built into `helpers.rangeFromLineNumber`.
-
-
Update eslint-config-airbnb-base to version 8.0.0
π (#715)* chore(package): update eslint-config-airbnb-base to version 8.0.0 * Update eslint-plugin-import to v1.16.0 Needed to satisfy the `peerDependencies` of `[email protected]`. * Fix lint issues * Update ESLint disable style Turns out you can send mutliple rules to `eslint-disable-next-line`.
-
-
Merge pull request #666 from einarlove/ignore-rule-ids
Add setting for silencing rule ids
-
Only specify the setting if there are rules to ignore
If the user hasn't configured any rules, don't add the argument.
This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 4414384AEEE3FB2B Learn about signing commits -
Move ignoredRulesWhenModified to file scope
Just like the other observed settings, for some reason it was out of scope when we tried to access it.
Arcanemagus committedSep 28, 2016 This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 4414384AEEE3FB2B Learn about signing commits -
Update the value expected to account for the proper spec initialization.
Arcanemagus committedSep 28, 2016 This commit was signed with a verified signature.Arcanemagus Landon Abney
GPG key ID: 4414384AEEE3FB2B Learn about signing commits