Opened 5 years ago

Closed 13 months ago

Last modified 13 months ago

#8203 closed feature (fixed)

Button: Deprecate text option; rename to showLabel

Reported by: sp2 Owned by:
Priority: blocker Milestone: 1.12.0
Component: ui.button Version: 1.8.18
Keywords: Cc:
Blocked by: Blocking:

Description

Using 'text' as a boolean to control whether or not the button label is shown isn't very intuitive. It also could easily conflict with other frameworks that might use 'text' to set the label of a variety of controls. Can we change the name to something a little more descriptive, like 'showLabel' or 'showName'?

Change History (7)

comment:1 Changed 4 years ago by scottgonzalez

  • Type changed from enhancement to feature

comment:2 Changed 4 years ago by bernhardsirlinger

I already opened a pull request on GitHub fixing this issue. ​https://github.com/jquery/jquery-ui/pull/712

comment:3 Changed 4 years ago by scottgonzalez

  • Milestone changed from 1.9.0 to 1.11.0

comment:4 Changed 4 years ago by tj.vantoll

  • Status changed from new to open

We'll look at this when button's API is readdressed in 1.11.

comment:5 Changed 3 years ago by scottgonzalez

  • Milestone changed from 1.11.0 to none

comment:6 Changed 13 months ago by scottgonzalez

  • Milestone changed from none to 1.12.0
  • Resolution set to fixed
  • Status changed from open to closed
  • Summary changed from 'text' is a confusing name for the option to Button: Deprecate text option; rename to showLabel

comment:7 Changed 13 months ago by scottgonzalez

  • Priority changed from minor to blocker
Note: See TracTickets for help on using tickets.