Opened 6 years ago

Closed 2 years ago

#7041 closed bug (fixed)

Toggle size effect demo not working

Reported by: eccenux Owned by: mikesherov
Priority: minor Milestone: 1.12.0
Component: ui.effects.* (individual effect) Version: 1.8.9
Keywords: Cc:
Blocked by: Blocking:

Description

Steps

  1. Open page toggle demo.
  2. Select size effect.
  3. Click twice on Run effect.

Result

Background is not scaled back to the original size.

Not sure if this is a problem with demo options or with the "size" effect. Are there any options to make it work right?

Expected result

Toggle to the original size.

Change History (12)

comment:1 Changed 6 years ago by scottgonzalez

  • Component changed from [meta] ui.demos to effects.* (individual effect)

comment:3 Changed 6 years ago by gnarf

  • Status changed from new to open

Reviewing the pull by kzys has got me wondering if .toggle("size") makes any sense. We should at minimum document this to/from swapping behaviour and limit it to ONLY when using .toggle() ...

Last edited 6 years ago by gnarf (previous) (diff)

comment:4 Changed 6 years ago by gnarf

Also - Which direction do you think makes more sense to be from vs to ? Showing goes to -> from ?

I would think that Showing goes from -> to and hiding goes to -> from , but only when your original mode is toggle

​https://github.com/jquery/jquery-ui/pull/203#commitcomment-369756 might give you a better idea of a use case.

Last edited 6 years ago by gnarf (previous) (diff)

comment:5 Changed 6 years ago by gnarf

  • Owner set to kzys
  • Status changed from open to assigned

comment:6 Changed 4 years ago by scottgonzalez

  • Milestone changed from 1.9.0 to 1.10.0

comment:7 Changed 4 years ago by mikesherov

  • Cc gnarf scott.gonzalez added

There is a valid pull request still here! It was only closed because it no longer merged cleanly: ​https://github.com/jquery/jquery-ui/pull/203 If someone can rebase, perhaps it can be rescued... scott?

comment:9 Changed 4 years ago by mikesherov

  • Keywords haspatch added

comment:10 Changed 4 years ago by tj.vantoll

  • Milestone changed from 1.10.0 to none

comment:11 Changed 2 years ago by mikesherov

  • Cc gnarf scott.gonzalez removed
  • Keywords haspatch removed
  • Milestone changed from none to 1.12.0
  • Owner changed from kzys to mikesherov

This will be fixed by the effects rewrite.

comment:12 Changed 2 years ago by Mike Sherov

  • Resolution set to fixed
  • Status changed from assigned to closed

Effects: Rewrite

  1. Introduces a set of helper methods to easily create and define new effects.
  2. Uses clip animations and placeholders instead of wrappers for clip effects.
  3. Ensures all animations are detectable as animated

Fixes #10599 Fixes #9477 Fixes #9257 Fixes #9066 Fixes #8867 Fixes #8671 Fixes #8505 Fixes #7885 Fixes #7041

Closes gh-1017

Changeset: b6bec797d6a8ef0b377a866c38c67e66a626b45f

Note: See TracTickets for help on using tickets.