/phpbb

Add viewforum_body_topicrow_before template event #4338

Merged
merged 1 commit into from Aug 28, 2016
+14 −2

Labels

3.1 (Ascraeus) Event

Milestone

  3.1.10

Assignees

No one assigned

5 participants

@Senky @Elsensee @3D-I @Crizz0 @marc1706
@Senky
Senky commented May 29, 2016

PHPBB3-14469

@Crizz0 Crizz0 added this to the 3.1.10 milestone Jun 21, 2016
@marc1706 marc1706 commented on an outdated diff Jul 17, 2016
View full outdated diff
phpBB/docs/events.md
@@ -2227,6 +2227,14 @@ viewforum_body_topic_row_prepend
* Since: 3.1.7-RC1
* Purpose: Add content at the end of the topic list item.
+viewforum_body_topicrow_before
@marc1706
phpBB Forum Software member
marc1706 added a line comment Jul 17, 2016

To be consistent with the other events regarding the topicrow, we should probably change it to viewforum_body_topic_row_before` and move it accordingly before the entries above this one to have a proper alphabetical order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@Elsensee
phpBB Forum Software member
Elsensee commented Jul 28, 2016

events.md is in alphabetical order. Thus viewforum_body_topicrow_before needs to be moved up, so it's before viewforum_body_topicrow_prepend.

@marc1706 marc1706 merged commit 317f3e8 into phpbb:3.1.x Aug 28, 2016
1 check passed

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
@3D-I 3D-I commented on the diff Aug 29, 2016
View full changes
phpBB/docs/events.md
@@ -2227,6 +2227,14 @@ viewforum_body_topic_row_prepend
* Since: 3.1.7-RC1
* Purpose: Add content at the end of the topic list item.
+viewforum_body_topicrow_row_before
@3D-I
3D-I added a line comment Aug 29, 2016

Shouldn't it be viewforum_body_topicrow_before ¿?

Applies to all of this files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@3D-I
3D-I commented Aug 29, 2016

I added a comment to the commit.

It should be viewforum_body_topicrow_before and not viewforum_body_topicrow_row_before, I guess.

@Senky Senky deleted the Senky:ticket/14469 branch Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment