WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#36017 closed defect (bug) (fixed)

Add Device Preview to the Theme-install Previewer

Reported by: celloexpressions Owned by: ocean90
Milestone: 4.5 Priority: normal
Severity: normal Version: trunk
Component: Themes Keywords: has-patch has-screenshots
Focuses: ui Cc:

Description

The theme-install previewer uses the same UI framework as the customizer, and allows themes to be previewed with generic content from wordpress.org. We should bring the device preview buttons in the customizer to this interface as well, so that themes can be easily previewed on various device sizes before being installed.

Attachments (3)

36017.diff​ (8.3 KB) - added by celloexpressions 4 months ago.
theme-install-device-preview.gif​ (2.1 MB) - added by celloexpressions 4 months ago.
With 36017.diff​.
36017.2.diff​ (8.9 KB) - added by ocean90 4 months ago.

Change History (6)

@celloexpressions
4 months ago

@celloexpressions
4 months ago

With 36017.diff​.

#1 @celloexpressions
4 months ago

Note that the patch moves the CSS to themes.css and adjusts selectors so that it can be used for both versions. Also, the available devices are intentionally not customizable in this UI, since plugins are generally restricted from doing much to this interface directly.

#2 @mikeschroder
4 months ago

  • Owner set to ocean90
  • Status changed from new to assigned
  • Type changed from enhancement to defect (bug)

Changing this to bug, since it's something caught that was missed in #31195.

@ocean90
4 months ago

#3 @ocean90
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 36858:

Themes: Bring the device preview from [31195] to the theme install previewer.

Props celloexpressions.
Fixes #36017.

Note: See TracTickets for help on using tickets.