Add basic SPDX tag/value (and also RDF) output #430

Merged
merged 7 commits into from Jan 5, 2017

Projects

None yet

3 participants

@sschuberth
Collaborator

Please have a look at the individual commit messages for the details.

@pombredanne
Member

@sschuberth it sounds like the introduction of html5lib did modify the behavior of BeautifulSoup which uses it when/if available hence some completely unrelated markup cleanup tests are now failing ... I will look into this.

@sschuberth
Collaborator

I will look into this.

Thanks!

@pombredanne
Member

@sschuberth how do you want me to proceed?
I can push your branch with extra commits to a scancode branch and submit a PR to you?

@sschuberth
Collaborator

Sounds good, except that you don't have to file a PR with my fork. I'll take your changes directly from your branch.

@pombredanne
Member

@sschuberth I pushed https://github.com/nexB/scancode-toolkit/tree/338-spdx-tv and this has afew extra commits and all tests pass on Linux for now.

The main fix was to upgrade beautifulsoup4 and regenerate/review some expectations in tests.

The builds are running at https://ci.appveyor.com/project/nexB/scancode-toolkit/build/314 and at https://travis-ci.org/nexB/scancode-toolkit/builds/189249129

@DennisClark

@sschuberth The addition of SPDX support to scancode is wonderful, and something we have been wanting for quite a while !!! Thanks, I intend to try it out as soon as possible.

@sschuberth sschuberth changed the title from Add basic SPDX tag/value (also also RDF) output to Add basic SPDX tag/value (and also RDF) output Jan 5, 2017
sschuberth and others added some commits Jan 3, 2017
@sschuberth sschuberth cli: Only create JSON acknowledgment if needed
This helps to keep the code for the individual output formats a bit more
separate.
be4e1eb
@sschuberth sschuberth Add basic SPDX tag/value output
Closes #338.
312404b
@sschuberth sschuberth Add the spdx-tools package and dependencies as thirdparty
The packages were downloaded via

$ pip download -d thirdparty/prod/ spdx-tools
dfa79d8
@sschuberth sschuberth Update existing thirdparty packages
This is a preparation for installing spdx-tools and its dependencies.

Thanks to @pombredanne for also bumping beautifulsoup4 so it works with
html5lib.
17cda43
@sschuberth sschuberth Add ABOUT and LICENSE files for the spdx-tools package and dependencies
Thanks to @pombredanne for creating all of these except the ones for
spdx-tools.
62ca88f
@sschuberth sschuberth Add basic SPDX RDF output
3ab4da1
@pombredanne pombredanne Update test expectations for latest beautifulsoup4
 * regenerated expected files and reviewed them.
 * the demarkup is actually improved.

Signed-off-by: Philippe Ombredanne <[email protected]>
a00ab45
@sschuberth
Collaborator

Thanks @pombredanne, I've incorporated most of your changes, some of them squashed to make a more readable history.

@DennisClark Thanks for the praise! I expect there to be rough edges, but it's a start and should be easy to improve now.

@pombredanne
Member

Looking good and merging in.

@pombredanne pombredanne merged commit 9aba333 into nexB:develop Jan 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sschuberth sschuberth deleted the sschuberth:spdx-tv branch Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment