/video.js

docs(contributing.md): update CONTRIBUTING.md with latest info #3722

Merged
merged 7 commits into from Nov 4, 2016

Labels

None yet

Milestone

  5.13

Assignees

No one assigned

3 participants

@gkatsev @misteroneill @mister-ben
@gkatsev
Video.js member
gkatsev commented Oct 26, 2016

No description provided.

CONTRIBUTING.md
@@ -30,92 +64,60 @@ Guidelines for bug reports:
3. Isolate the problem — **create a [reduced test case](https://css-tricks.com/reduced-test-cases/)** with a live example. You can possibly use [this JSBin example](http://jsbin.com/axedog/7/edit) as a starting point.
@mister-ben
mister-ben Oct 26, 2016

This jsbin has video.js 4.1

@gkatsev
gkatsev Oct 26, 2016 Video.js member

oops, forgot to update to the newer one.

CONTRIBUTING.md
-contrib feature start
+```sh
+$ cp sandbox/index.html.example sandbox/index.html
+$ open sandbox/index.html
@mister-ben
mister-ben Oct 26, 2016

Is it a good idea to encourage opening from file:// ?

@misteroneill
misteroneill Oct 27, 2016 Video.js member

Maybe suggest running npm start and heading over to localhost:9999/sandbox/?

@gkatsev
gkatsev Oct 27, 2016 Video.js member

Yes, though, that's literally the next section.

CONTRIBUTING.md
[GitHub Issues](https://github.com/videojs/video.js/issues) are used for all discussions around the codebase, including **bugs**, **features**, and other **enhancements**.
+When filling out an issue, make sure to fill out the questions in the
### Reporting a Bug
**A bug is a demonstrable problem** that is caused by the code in the repository. Good bug reports are extremely helpful. Thank You!
@mister-ben
mister-ben Oct 26, 2016

Maybe add a more explicit note that bugs in plugins should be filed against those plugins.

@gkatsev
gkatsev Oct 27, 2016 Video.js member

Good idea.

@gkatsev
gkatsev Nov 2, 2016 Video.js member

Done.

@gkatsev gkatsev updated

All checks have passed

2 successful checks
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.8%) to 83.715%
8436e64
@gkatsev gkatsev modified the milestone: 5.13 Nov 2, 2016
@gkatsev gkatsev merged commit 11a096d into videojs:master Nov 4, 2016
2 checks passed

2 checks passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
Details coverage/coveralls Coverage decreased (-0.8%) to 83.715%
@gkatsev gkatsev deleted the gkatsev:contributing branch Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment