/schemaorg

New issue

Parent type for BroadcastService #493

Closed
unor opened this Issue May 14, 2015 · 4 comments

Labels

schema.org vocab type:bug type:cleanup + clarity

Milestone

  sdo-ganymede release

Assignees

No one assigned

3 participants

@unor @danbri @vholland
@unor
unor commented May 14, 2015

Currently BroadcastService is a direct child of Thing.

Can we make it a child of Service, or some other type?

@danbri danbri added this to the sdo-ganymede milestone May 14, 2015
@danbri
danbri commented May 14, 2015

Thanks, sounds like a bug. I believe /Service was discussed as a parent. @vholland ?

@vholland
vholland commented May 14, 2015

That is my recollection as well. In particular, inheriting the serviceArea property is needed. I'm guessing I missed adding the supertype when I modified the schema.

@unor
unor commented May 14, 2015

Ah, was suggested here: #315

@danbri danbri added a commit that closed this issue May 14, 2015
@danbri danbri Somehow we reverted #315 and 217ac4c 
This fixes  #315 again, defining Service as the supertype of BroadcastService.
Thanks @unor for reporting this and @vholland for confirming the intent.
Fixes #493
 b7b6d2a
@danbri danbri closed this in b7b6d2a May 14, 2015
@danbri
danbri commented May 14, 2015

Odd, it looks from #315 and 217ac4c that the supertype was added.

I've re-fixed it, and pushed the changes to work-in-progress builds on sdo-ganymede.appspot.com (our next release branch) + http://webschemas.org/BroadcastService which is a kind of volatile/wobbly upstream test site whose name doesn't change per-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment