/facebook-python-ads-sdk

examples/read_objects.py is broken: ImportError: cannot import name AdCampaign #297

Closed
uppercasebrands opened this Issue Mar 31, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@uppercasebrands @advance512 @daphyFB
@uppercasebrands
Contributor

uppercasebrands commented Mar 31, 2017

python read_objects.py -h
Traceback (most recent call last):
File "read_objects.py", line 27, in
from facebookads.objects import (
ImportError: cannot import name AdCampaign

Seems like version 2.8 changed AdCampaign to Campaign.

There are a few more bugs in read_objects.py regarding deprecated names and methods.

uppercasebrands added a commit to uppercasebrands/facebook-python-ads-sdk that referenced this issue Mar 31, 2017

@uppercasebrands
Fixed issue #297, tested against live data
eb32bb7
@advance512

advance512 commented Apr 12, 2017

LGTM

daphyFB added a commit that referenced this issue Apr 27, 2017

@uppercasebrands @daphyFB
Bugfix 304: unittest now works (#305) 
* Fixed issue #297, tested against live data

* API is updated to 2.8.2

* Fix issue 304: corrected the unittests in test/unit.py

* revert examples/read_objects.py

* revert examples/custom_audience_utils.py

* Revert "Merge branch 'bugfix-304-unittest'"

This reverts commit 151e7b7, reversing
changes made to 3836081.

* Revert "Merge remote-tracking branch 'upstream/master'"

This reverts commit 3836081, reversing
changes made to 70a79e0.

* Revert "Revert "Merge branch 'bugfix-304-unittest'""

This reverts commit c8d5a82.

* Revert "Revert "Merge remote-tracking branch 'upstream/master'""

This reverts commit 673725a.
6f56165

daphyFB added a commit that referenced this issue Apr 27, 2017

@uppercasebrands @daphyFB
Fixed issue #297, tested against live data (#298) 
* Fixed issue #297, tested against live data

* API is updated to 2.8.2

* Fix issue 304: corrected the unittests in test/unit.py

* revert examples/read_objects.py

* revert examples/custom_audience_utils.py

* Revert "Merge branch 'bugfix-304-unittest'"

This reverts commit 151e7b7, reversing
changes made to 3836081.
1760595
@daphyFB
Contributor

daphyFB commented Apr 28, 2017

the fix has been merged.

@daphyFB daphyFB closed this Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment