Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Try hiding block toolbar under ellipsis #2248
Conversation
iseulde
added the
Design
label
Aug 6, 2017
iseulde
requested review from karmatosed, mtias, jasmussen, and melchoyce
Aug 6, 2017
iseulde
deleted a comment
from codecov bot
Aug 6, 2017
iseulde
deleted a comment
from codecov bot
Aug 6, 2017
|
While I do love how this looks, I'm not convinced that it's a good solution. It hides a lot of important stuff behind a small touch target, and adds friction. While not as good looking or contextual, I think the fixed toolbar (#2148) is a better "plan b" if we can't get the current system to feel lightweight enough. |
|
@jasmussen Could you elaborate on the friction? Which flow?
…
|
|
Sure. Right now you click the block itself to surface the quick toolbar. This is a big and easy touch target. Although I love the visual minimalism of the little ellipsis, it's a smaller touch target. |
|
If the touch target is too small, we could always make it bigger. Anyway, it was worth a try. :) |
|
No exploration is wasted. Everything becomes part of the whole picture. If an avenue was explored and abandoned, it's an avenue cauterized, and intentionally not chosen. That has great value too. |
iseulde commentedAug 6, 2017
•
edited
This is an alternative to #2148 and tries to address the blocky feel/noisy UI feedback.
I'm not proposing to merge this, it's just a proof of concept.
Think of it a bit as the right-click of Gutenberg.
Here are the states:
Things I like about this:
Things I don't like about this:
Maybe we need block setting for "object-like" blocks such as images. There it would make sense to show the toolbar all the time, though I don't mind it when I think about it as right-click for Gutenberg. It makes it feel less heavy overall.