/gutenberg

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

eslint: remove browser env #1008

Merged
merged 1 commit into from Jun 2, 2017

Conversation

Reviewers

@aduth aduth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@iseulde @aduth
@iseulde
Member

iseulde commented Jun 2, 2017

To prevent bugs like #1007, I would suggest removing browser from eslint settings.
@iseulde iseulde eslint: remove browser env

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
f695e2b

@iseulde iseulde requested a review from aduth Jun 2, 2017

@aduth

aduth approved these changes Jun 2, 2017
View changes

I'm on board 👍

@aduth
Member

aduth commented Jun 2, 2017

@ntwb Perhaps of interest to you. See also #1007, #1007 (comment) .

@iseulde iseulde merged commit ce9abd8 into master Jun 2, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@iseulde iseulde deleted the try/eslint-no-browser branch Jun 2, 2017

This was referenced Jun 13, 2017

Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment