Fix to work fiber debugger with npm start #8811

Merged
merged 4 commits into from Jan 17, 2017

Projects

None yet

3 participants

@koba04
Contributor
koba04 commented Jan 17, 2017

I tried to work ReactFiber Debugger by the following way. But it doesn't work.

Running

First, npm run build in React root repo folder.

Then npm install and npm start in this folder.

Open http://localhost:3000 in Chrome.

This PR is to fix that.
To do that, is it ok to add fiber.js into react-dom?

In addition to that, I've fixed warnings about keys.

Thanks.

@gaearon
Member
gaearon commented Jan 17, 2017

Oh, I think it didn't work because I deleted React from package.json but not from Yarn lockfile. Could you try just removing React from lockfile? That should work too.

@koba04
Contributor
koba04 commented Jan 17, 2017

@gaearon Thanks! You are right. I missed .env and CRA is using dotenv. This issue is only react-dom is in yarn.lock.

@gaearon
Member
gaearon commented Jan 17, 2017

This looks good, thanks! To be clear, your approach would also work, I'm just not sure if file: is supported in all versions of Node or not.

@gaearon gaearon merged commit 0758bb0 into facebook:master Jan 17, 2017

1 check was pending

ci/circleci Your tests are queued behind your running builds
Details
@koba04 koba04 deleted the koba04:fix-to-work-fiber-debugger-with-npm-start branch Jan 17, 2017
@koba04
Contributor
koba04 commented Jan 17, 2017

Thanks!

file: is supported in all versions of Node or not.

I'm using file: with npm v2 and v3, which is fine. But I'm not sure it works in all environments including Windows :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment