Skip to content

/otwarchive

AO3-4523 Fix collapse/expand fandoms link on dashboard #2405

Merged
merged 1 commit into from May 28, 2016
+1 −1

Labels

Reviewed: Ready to Merge

Milestone

No milestone

Assignees

No one assigned

3 participants

@sarken @shalott @zz9pzza
@sarken
Organization for Transformative Works member
sarken commented Mar 24, 2016

https://otwarchive.atlassian.net/browse/AO3-4523

Both the Expand and Collapse options were showing on the fandoms list. We only want the one that applies to show.

@sarken sarken commented on the diff Mar 24, 2016
View full changes
public/stylesheets/site/2.0/09-roles-states.css
@@ -42,7 +42,7 @@ span.unread, .replied, span.claimed, .actions span.defaulted {
font-weight: 700;
}
-.hidden, body .hidden, .actions .hidden {
+.hidden, body .hidden, .actions .hidden, .actions a.hidden {
@sarken
Organization for Transformative Works member
sarken added a note Mar 24, 2016

Our actions are usually lists like <ul class="actions"><li class="hidden"><a href="">Link</a></li></ul>, but on the dashboard fandoms lists, it's <p class="actions"><a href="">Link</a> <a href="" class="hidden">Link</a></p> because we only ever show one link at a time, so a list isn't very appropriate.

Alas, this meant the display: inline-block we use on .actions farther down our cascade was overriding the display: none here. Adding another selector with some heft will fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@zz9pzza zz9pzza merged commit 6924aad into otwcode:master May 28, 2016
1 check passed

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.