New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable some Stylelint color-related rules to slightly reduce file sizes #17076
Enable some Stylelint color-related rules to slightly reduce file sizes #17076
Conversation
Snuffleupagus
commented
Oct 5, 2023
- Use a consistent format for all alpha-values (this rule didn't require any code changes); see https://stylelint.io/user-guide/rules/alpha-value-notation
- Use modern and slightly shorter color notation, since according to MDN that should be supported "everywhere" nowadays; see https://stylelint.io/user-guide/rules/color-function-notation/
- Use "short" hexadecimal colors whenever possible; see https://stylelint.io/user-guide/rules/color-hex-length/
- Help avoid adding broken hexadecimal colors (this rule didn't require any code changes); see https://stylelint.io/user-guide/rules/color-no-invalid-hex/
- Use a consistent format for all alpha-values (this rule didn't require any code changes); see https://stylelint.io/user-guide/rules/alpha-value-notation - Use modern and slightly shorter color notation, since [according to MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/rgb#browser_compatibility) that should be supported "everywhere" nowadays; see https://stylelint.io/user-guide/rules/color-function-notation/ - Use "short" hexadecimal colors whenever possible; see https://stylelint.io/user-guide/rules/color-hex-length/ - Help avoid adding broken hexadecimal colors (this rule didn't require any code changes); see https://stylelint.io/user-guide/rules/color-no-invalid-hex/
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d3ba8913f8b3273/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d3ba8913f8b3273/output.txt Total script time: 1.54 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8d12aa9b3879789/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d266d972a3762fc/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/8d12aa9b3879789/output.txt Total script time: 26.88 mins
Image differences available at: http://54.241.84.105:8877/8d12aa9b3879789/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d266d972a3762fc/output.txt Total script time: 38.19 mins
Image differences available at: http://54.193.163.58:8877/d266d972a3762fc/reftest-analyzer.html#web=eq.log |
|
Running makeref here, since it recently failed in PR #17075 because the branch was removed too soon. /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/bfe7590d5f21a65/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9061b12a99e7e14/output.txt |
|
arff... my bad, sorry about that. |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9061b12a99e7e14/output.txt Total script time: 21.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/bfe7590d5f21a65/output.txt Total script time: 24.43 mins
|