Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Make all metadata optional in AMP. #593
Conversation
cramforce
added
NEEDS REVIEW
Category: Validator
labels
Oct 13, 2015
cramforce
assigned
erwinmombay
Oct 13, 2015
|
Does the validator currently check against this requirement? |
|
I don't believe it does. Labeled this issue to check.
|
erwinmombay
assigned
powdercloud
and unassigned
erwinmombay
Oct 13, 2015
|
reassigning to @powdercloud to answer the validator question |
kevinmarks
commented
Oct 13, 2015
|
What's the goal of requiring the article type here? In the search demo I can see that the image, headline published date and publisher logo were used to create the SERP previews, but not what role the explicit article type plays. Possibly more useful would be a deterministic algorithm for constructing SERP previews of that type, with examples drawn from existing pages. |
|
How things get marked up to show up in Google Search is a Google issue. The The reason why I think marking up the type is useful is that browsers could
|
tantek
commented
Oct 13, 2015
|
"The reason why I think marking up the type is useful is that browsers could use that to make similar heuristic decisions as AMP, so they could optimize things and we no longer need AMP. Maybe we don't need it. I'd be fine to drop the requirement, but I think it'd be a net win." Key phrases you used:
Then why not drop the requirement until a browser implementer comes forward with a concrete use-case that needs it (rather than "could")? A simpler spec (fewer requirements) is a better spec. And as @kevinmarks indicated, there's a good chance we can nullify any such direct need for explicit typing through a concrete Type Discovery algorithm, developed naturally based on (cited) real world publishing experience. |
|
No need to quote my words out of context. That comes across rather If people would prefer to continue the right to not use semantic markup in
|
tantek
commented
Oct 13, 2015
|
No need to tone-police. My point was your words justified the opposite of your conclusion. The burden of proof of any feature (requirement) in a spec is for its existence, dropping is the default choice because simpler specs tend to be better, more secure, easier for authors etc. Without a good real world use-case based argument for why any particular markup (semantic, meta, or otherwise) is needed, there's no justification for requiring it. Less is better. Otherwise it's just bloat. |
|
The validator itself isn't checking, it just allows it. Reason being we're not parsing up the json thus far. However de facto for the preview release I believe the articles do have the markup, and some other code (not the validator) is looking for this markup. My hunch is that it's useful to put some markup about the articles into the spec (headline, author, etc.) because it lowers the barrier of entry for anyone to deliver these articles: No need for fancy detection algorithms or parsing stuff like headline, author, publishing date from the contents. |
|
@tantek I will strictly enforce a be-excellent-to-each-other code-of-conduct on this open source project. You were escalating a discussion that really had nobody really disagreeing heavily with each other. I can be very much convinced to remove all semantic markup requirements from the AMP spec. I think your spec simplicity argument is great! @powdercloud That hunch is a pretty good one, I think. Mandating baseline semantic markup helps smaller AMP consumers that cannot effectively mandate markup themselves (like Google, Bing, Yandex, Twitter Facebook) to get predictable structured data. I think practically speaking there are pretty good libraries that just extract from a page what they get get independent of whether the author used schema.org, OGP or Twitter cards, so it doesn't really matter all that much. |
kevinmarks
commented
Oct 13, 2015
|
There are no public libraries I know of that parse schema.org; last time I asked danbri he said that they don't exist. https://twitter.com/danbri/status/616164347073662976 |
|
CC @danbri |
cramforce
changed the title from
Only require schema.org article type. Nothing else.
to
Make all metadata optional in AMP.
Oct 13, 2015
|
Updated to remove all metadata requirements. |
cramforce
assigned
dvoytenko
and unassigned
powdercloud
Oct 13, 2015
|
Oh, how I have missed these debates! |
dvoytenko
added
LGTM
and removed
NEEDS REVIEW
labels
Oct 13, 2015
|
LGTM |
cramforce commentedOct 13, 2015
Related to #499