Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Try sliding toolbar for overflow on mobile #2443
Conversation
jasmussen
added
Chrome
Needs Design Feedback
[Component] Mobile
labels
Aug 17, 2017
jasmussen
self-assigned this
Aug 17, 2017
jasmussen
requested review from karmatosed, mtias, and melchoyce
Aug 17, 2017
|
Here's how the Android app does it: https://cloudup.com/c9O9cRkfx0K |
jasmussen
referenced this pull request
Aug 17, 2017
Closed
Can we get to just two block toolbars? #2429
|
Merging because the tests pass, it's a trivial change, and I got a thumbs up in chat! |
jasmussen
merged commit f777f79
into
master
Aug 18, 2017
jasmussen
deleted the
try/sliding-mobile-toolbar branch
Aug 18, 2017
|
:-( |
|
Right, the only way I can see to make the drop-down menu work again is to set the position using Javascript. |
|
Because it relied on being able to position relative to the button and now the button does not allow any overflow. The only reason the block switcher still works is that it always ignored the position of the button when displaying the drop-down. |
|
Going to try something, I have an idea. |
EphoxJames
added a commit
that referenced
this pull request
Aug 22, 2017
|
|
EphoxJames |
598e034
|
This was referenced Aug 22, 2017
EphoxJames
added a commit
that referenced
this pull request
Aug 29, 2017
|
|
EphoxJames |
a9de9d2
|
jasmussen commentedAug 17, 2017
This PR may fix #2287, at least partially, or in a transitional way. It's a two-line code change, and all it does is ensure that on mobile, overflow can be scrolled.
This is not a good solution for desktop, of course, where the scrollbar when visible (as it is on nearly all computers) would not only cover content and be ugly, but scrolling horizontally is generally not a good experience. However on mobile, the scrollbar fades in briefly when you load the page, and you can just drag with your finger.
Let's discuss whether this is a good solution.
Demo: