Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Flow for creating lists from text #539
Comments
mtias
added
Blocks
[Type] Task
labels
Apr 28, 2017
mtias
added
to List in Blocks
Apr 28, 2017
|
To elaborate a bit, this might be particularly interesting in combination with the multi paragraph text block, #447. In this case, selecting items inside such a block and clicking the list block would "split the block". |
|
I think these transformations should appear on the block switcher because I expect creating a list to split it into a separate block. |
jasmussen
added this to the
Beta
milestone
May 16, 2017
|
If the list has indents what should the conversion from list to paragraph do? |
|
Probably okay to remove the indentation in the conversion then. We can always revisit if we find that too destructive. |
jasmussen
modified the milestone: May Week 4: Beta, May 29 to Jun 2, Beta, Beta, Nice To Have
May 30, 2017
kopepasah
moved
from Backlog to Ready in Blocks
Jun 29, 2017
jasmussen
modified the milestone: Beta 0.8.0, Beta, Nice To Have, Beta 0.6.0
Jul 5, 2017
|
@jasmussen @mtias Is this still relevant? |
It is on a meta level. I think we have many many aspects right with the editor in its current state. But one of the aspects I still think needs a little polish is cross-text-block actions like list or quote making. It might have to be punted, but I think it's worth keeping this open. |
|
@iseulde we need to review transformations in general, both UI and technically. This falls under that. I feel it should be more contextual (if you select multiple lines you get option to create list, otherwise you don't). |
mtias
modified the milestone: Beta 0.7.0, Beta 0.6.0
Jul 24, 2017
jasmussen
added a commit
that referenced
this issue
Aug 2, 2017
|
|
jasmussen |
3474036
|
mtias
modified the milestone: Beta 0.8.0, Beta 0.7.0
Aug 2, 2017
|
Here's a new mockup: In this situation, you get a new quick toolbar, one which works across blocks. @iseulde what do you think? |
|
@jasmussen I thought we were going for the blue toolbar on top? |
|
I still like that blue toolbar, it's an option. If it's easier to implement like that, it's okay. The mockup tries a quick toolbar instead, as it adds actions related to formatting. |
|
Yes, I initially made it like this. I think we removed it because of the sticky toolbar problem (would be limited to the first block). Not sure how to solve that problem. |
If it's easier to do in the blue toolbar for now, totally fine, especially since we're pondering a fixed toolbar in #2148. Doing a little inspector surgery, if we can move the block controls to be a child of this div, then it can scroll across the blocks: But if that's super complicated, totally fine to use the blue one. |
|
@jasmussen Don't think that's true. It would scroll over all the blocks and not get fixed anywhere but the top and bottom of the editor. |
|
We can wrap selected blocks in a div (easy with React I guess), but then all iframes will reload every time you multi select them. |
|
Sounds like we should try putting the buttons in the blue bar for starters, seeing if it's actually a good flow. Then we can iterate from there. |






mtias commentedApr 28, 2017
•
edited by jasmussen
Idea discussed with @jasmussen.
If you select text across multiple lines, a contextual "make a list out of these" button could appear next to the block switcher.
Clicking it would create a new list block with those items.
See comments for a mockup of how this could work.