Update settings page cache on/off process. #255

Merged
merged 9 commits into from Jun 9, 2017

Conversation

Projects
None yet
1 participant
Contributor

donnchawp commented Jun 7, 2017

See #224.

Legacy caching wasn't a great name for the "default caching" this plugin
does, and only technical people will recognise PHP and mod_rewrite so we
simplified it.

Simple = PHP
Expert = mod_rewrite

And no mention of legacy caching which has become "standard caching".

@donnchawp donnchawp Update settings page cache on/off process.
Legacy caching wasn't a great name for the "default caching" this plugin
does, and only technical people will recognise PHP and mod_rewrite so we
simplified it.

Simple = PHP
Expert = mod_rewrite

And no mention of legacy caching which has become "standard caching".
e00cc3f

donnchawp self-assigned this Jun 7, 2017

Contributor

donnchawp commented Jun 7, 2017

Looks something like this (currently):

screen shot 2017-06-07 at 17 35 25

Contributor

donnchawp commented Jun 8, 2017

A weakness of this UI is that "Standard Caching" has to be enabled for "Super Caching" to be enabled. The control for both maybe should be one element. Maybe radio boxes?

  1. Standard Caching
  2. Super Caching (includes Standard Caching)
Contributor

donnchawp commented Jun 8, 2017

After the last code check in:

screen shot 2017-06-08 at 13 17 58

@donnchawp donnchawp Simplify cache type settings to on/off switch.
Add "DISABLE_SUPERCACHE" constant that disables supercache caching.
The on/off switch enables wp-cache and supercache caching by default.
c8a25e1
Contributor

donnchawp commented Jun 8, 2017

And now it's even simpler:

screen shot 2017-06-08 at 16 58 29

@donnchawp donnchawp merged commit 5fda1e6 into master Jun 9, 2017

donnchawp deleted the settings_page_cache_types branch Jun 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment