Disable caching in customize preview #161

Merged
merged 1 commit into from Feb 3, 2017

Projects

None yet

3 participants

@westonruter
Contributor

This is a first stab at ensuring compatibility with the customizer.

A bug report for 4.7 seems to indicate it is not compatible: https://core.trac.wordpress.org/ticket/39128

I'm trying to pin down where the problem lies exactly, but here's an initial stab at compatibility.

@kraftbj
Contributor
kraftbj commented Dec 9, 2016

@westonruter Thanks and this makes sense. Good to merge or do you think we should try to pin down things firmly first?

@kraftbj kraftbj added this to the 1.4.9 milestone Dec 9, 2016
@westonruter
Contributor

It does fix the one issue that I observed where changes failed to get applied in the preview after a refresh, so in that sense yes.

I've asked sixsigmablackbelt for more details on their configuration to figure out how to exactly reproduce the originally-reported issue.

@donnchawp
Contributor

I can't replicate this problem at all. I'm using a multisite and domain mapping and customizer works ok but the fix above looks harmless so I'm happy to merge this.

@donnchawp donnchawp merged commit 0a7bab6 into Automattic:master Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment