[ticket/14733] Support increasing hashing cost factor #4405
3 participants
| @@ -30,6 +30,14 @@ public function is_supported(); | ||
| public function is_legacy(); | ||
| /** | ||
| + * Check if password needs to be rehashed | ||
| + * | ||
| + * @param string $hash Hash to check for rehash | ||
| + * @return bool True if password needs to be rehashed, false if not | ||
| + */ | ||
| + public function needs_rehash($hash); |
|
Breaks other existing interface implementations, thus can not go into 3.1.x? As all drivers are extending the base class this shouldn't cause any BC breaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
|
This can not go into 3.1.x because of #4405 (comment). Additionally, it should not go into a stable branch because it is basically a new feature (with the usual possibility of regression/breaks).
I'm ok with moving this to 3.2.x as target. It shouldn't cause any BC breaks as it's using the abstract base class for an implementation of the de-facto state of the current convert flag. I do however understand that this is basically a new feature so I guess it's fair to have this moved to a 3.2.x target.
@Nicofuma agree?
@marc1706 An extension might implement driver_interface, no?
This will need another pull request for 3.2.x.
Checklist:
Tracker ticket (set the ticket ID to your ticket ID):
https://tracker.phpbb.com/browse/PHPBB3-14733
PHPBB3-14733