Investigate if sandboxing flag check can move to the PresentationRequest ctor #379

Closed
mfoltzgoogle opened this Issue Nov 29, 2016 · 3 comments

Comments

Projects
None yet
3 participants
Contributor

mfoltzgoogle commented Nov 29, 2016

Follow-up from Issue #362. It may be possible to check the sandboxing flag in the ctor for PresentationRequest, and this would simplify the algorithms that check it on function invocation.

However, if the attribute is dynamic or set on navigation, it may not be possible.

@mounirlamouri can you update this with what you discover in Blink?

Member

mounirlamouri commented Nov 30, 2016

Looking at Blink code, it seems to be dynamic. My understanding of the spec is that it's not.

@annevk do I misinterpret the spec?

Member

annevk commented Nov 30, 2016

I don't really understand the sandboxing setup. Too much forwarding of state.

Contributor

mfoltzgoogle commented Dec 1, 2016

Well, it would be safest to check it in both the PresentationRequest ctor and its functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment