setConnection in example 5.5 may put UI in an inconsistent state #339

Closed
mfoltzgoogle opened this Issue Sep 16, 2016 · 3 comments

Comments

Projects
None yet
4 participants
Contributor

mfoltzgoogle commented Sep 16, 2016

setConnection() calls close() on an existing connection before adding an onconnect handler to the new connection. If the close event on the old connection fires after the connect event on the new connection, reset() will null out the new connection and disable the stop and disconnect buttons.

mfoltzgoogle added the P3 label Sep 16, 2016

anssiko added the v1 label Sep 22, 2016

Contributor

tidoust commented Sep 26, 2016

See discussion at TPAC

ACTION: @kenchris to review and fix the example in 5.5

Contributor

kenchris commented Sep 30, 2016

Contributor

mfoltzgoogle commented Nov 16, 2016

Closing with the fixes in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment