Add allow-presentation to iframe sandbox flags #437
Comments
|
Do you have tests and implementation for this? Otherwise landing it in a couple of weeks, after we've branched the HTML 5.1 CR, sounds like a more likely approach. If you do already have interoperable implementation, feel free to prepare a PR any time today to reach the current milestone... |
|
OK, "now" was not meant to convey any sense or urgency, I did not know about the milestone. I suppose this can wait until after the CR branch. We don't have tests yet and implementations are still under development. |
chaals
added Needs tests Needs horizontal review
labels
Jun 1, 2016
chaals
added this to the
After HTML 5.1
milestone
Jun 1, 2016
|
@tidoust, ping? Are there implementations, tests, enough interop to set a concrete milestone for this? |
tidoust
modified the milestone: HTML 5.2 WD 2, For HTML 5.2
Nov 7, 2016
|
Hello @chaals, sandboxing tests for this flag are there:
Implementations:
In short, I believe we're mostly good and the Second Screen WG would like this flag to be integrated in HTML 5.2 as soon as possible. Would you like me to prepare a PR? |
chaals
referenced
this issue
Nov 7, 2016
Closed
May 2016 Port 6 - Add allow-presentation to sandbox flags #717
LJWatson
added security and removed Needs horizontal review
labels
Nov 29, 2016
chaals
modified the milestone: HTML 5.2 WD 6, For HTML 5.2
Mar 5, 2017
cynthia
was assigned
by chaals
Mar 5, 2017
anssiko
referenced
this issue
in w3c/presentation-api
Mar 22, 2017
Closed
[meta] Publish a revised Candidate Recommendation #406
|
@tidoust yes, we would love you to prepare a PR... |
chaals
modified the milestone: HTML 5.2 WD 7, HTML 5.2 WD 6
Apr 3, 2017
chaals
removed needs tests security
labels
Apr 3, 2017
tidoust
added a commit
to tidoust/html
that referenced
this issue
Apr 3, 2017
|
|
tidoust |
28692d4
|
tidoust
referenced
this issue
Apr 3, 2017
Merged
Adds allow-presentation to iframe sandbox flags #861
|
The checks on the sandboxing flag have been moved to the
These tests pass in Chrome Canary. |
chaals
pushed a commit
that referenced
this issue
Apr 5, 2017
|
|
tidoust + |
32c8a64
|
LJWatson
modified the milestone: HTML 5.2 WD 7, HTML 5.2 CR draft
Apr 30, 2017
|
done in 32c8a64 |
chaals
closed this
May 3, 2017
|
@tidoust so implementation is in canary and mozilla, and there are bugs? That's enough to mark it at-risk IMHO… |
|
@chaals Right, no objection from me to mark the feature as at-risk in HTML 5.2, with the understanding that if it cannot make it to HTML 5.2, the feature could still remain in the HTML Editor's Draft (unless the work on the Presentation API stops from some reason). I'll report on implementation status before the end of the HTML 5.2 CR period. |
tidoust commentedMay 30, 2016
The Presentation API spec, developed by the Second Screen Working Group, needs to introduce an
allow-presentationtoken to the set of tokens allowed in thesandboxattribute of aniframeelement, in order to allow calls to the Presentation API from nested frames, provided the parent browsing context allows it.The definition of this flag has been in the Presentation API spec for now:
http://w3c.github.io/presentation-api/#sandboxing-and-the-allow-presentation-keyword
As the Presentation API spec is getting ready for publication as Candidate Recommendation, now seems a good time to move the definition to where it should rather be, meaning in the HTML spec.
Note the flag has made its way to the WHATWG HTML spec a few days ago in whatwg/html@0678e3d
Not sure if you can cherry-pick the commit directly. Happy to prepare the corresponding PR for the HTML5.1 spec otherwise.
(For reference, related issue on the Second Screen Working Group issue tracker: w3c/presentation-api#299)