Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Install `phpcs` using Composer #1022
Conversation
nylen
added some commits
Jun 5, 2017
nylen
requested a review
from
westonruter
Jun 5, 2017
westonruter
added some commits
Jun 5, 2017
westonruter
added some commits
Jun 5, 2017
|
|
| @@ -8,7 +8,7 @@ charset = utf-8 | ||
| trim_trailing_whitespace = true | ||
| insert_final_newline = true | ||
| -[{package.json,.travis.yml}] | ||
| +[{package.json,.travis.yml,composer.json}] |
ntwb
Jun 6, 2017
Member
How about [{*.json,.travis.yml}] so it also covers .eslintrc.json and any other .json files?
westonruter
Jun 6, 2017
Owner
Done. This aligns better with core: https://github.com/WordPress/wordpress-develop/blob/4.7.5/.editorconfig#L16-L18
The package.json should be updated to use 2-space indents.
ntwb
referenced this pull request
Jun 6, 2017
Closed
Fix `.eslintrc.json` indentation, 2 spaces, not tabs #1029
nylen
merged commit 7c9cfe4
into
master
Jun 6, 2017
nylen
deleted the
update/phpcs-composer
branch
Jun 6, 2017
|
Thanks for the fixes & improvements here! |
This was referenced Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nylen commentedJun 5, 2017
•
Edited 1 time
-
westonruter
Jun 5, 2017
From #986 (comment), another way to install
phpcsandWordPress-Coding-Standardsis viacomposer. This PR explores this option.Still left to do:
phpcs --config-setcall, if possible