/document-register-element

New issue

Webpack out-of-box compatibility #66

Closed
treshugart opened this Issue Aug 24, 2016 · 2 comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@treshugart @WebReflection
@treshugart
treshugart commented Aug 24, 2016

It seems Webpack tries to build in its AMD shim when bundling the .max version in your bundle/ directory. I'm assuming that it finds what it thinks are references to define being used, but I haven't singled out exactly which lines of code are causing it to do that yet.
@treshugart treshugart referenced this issue Aug 24, 2016
Closed

fix: Webpack out-of-box compatibility #67

@treshugart
treshugart commented Aug 24, 2016

Figured it out and raised a PR. Unfortunately, I don't know of a good way to write a test for this (but I did run your tests and they pass).
@WebReflection
Owner
WebReflection commented Aug 24, 2016

the and module is https://github.com/WebReflection/document-register-element/blob/master/build/document-register-element.max.amd.js

however, I use define as function name in the generic one which is wrapped in a closure so I'm not sure why that bothers webpack.
@WebReflection WebReflection added a commit that closed this issue Aug 24, 2016
@WebReflection fixed #66 and improved #67 0e98e64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment