/wp-super-cache

Make sure updated $cache_path ends in '/' #77

Merged
merged 1 commit into from Feb 3, 2017
+3 −2

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

  1.4.9

3 participants

@omegadrh @kraftbj @donnchawp
@omegadrh
Contributor
omegadrh commented Nov 20, 2015

basename() removes the trailing slash, which is expected in the $cache_path variable / config file. Without this fix, you can enter /some/path/wp-content/cache/ and end up with /some/path/wp-content/cachesupercache/ , .../wp-content/cachemeta/ , etc.

Also, don't bother updating the config file if the path hasn't changed.
@omegadrh omegadrh Make sure updated $cache_path ends in '/' 
basename() removes the trailing slash, which is expected in the $cache_path variable / config file. Without this fix, you can enter /some/path/wp-content/cache/ and end up with /some/path/wp-content/cachesupercache/ , .../wp-content/cachemeta/ , etc.

Also, don't bother updating the config file if the path hasn't changed.
 f2bf9cf
@kraftbj kraftbj added the bug label Nov 24, 2015
@kraftbj kraftbj added this to the 1.4.7 milestone Nov 24, 2015
@kraftbj
Contributor
kraftbj commented Nov 24, 2015

Looks good to me. Going to get a second 👍.
@donnchawp donnchawp merged commit 1d62de9 into Automattic:master Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment