PresentationConnection.url should be optional? #325

Closed
mfoltzgoogle opened this Issue Jul 13, 2016 · 2 comments

Comments

Projects
None yet
1 participant
Contributor

mfoltzgoogle commented Jul 13, 2016 edited

The algorithm steps for creating a PresentationConnection set the url attribute after construction. It seems like we should make the attribute optional (like id) since it is not set in the constructor.

Contributor

mfoltzgoogle commented Jul 13, 2016

Three algorithms that create PresentationConnection objects and set attributes after construction:

Alternatively, we could define a constructor that takes the url and id and modify the algorithms to use that; which seems better, since the API is not intended is to expose PresentationConnections without these properties set.

Contributor

mfoltzgoogle commented Aug 18, 2016

Reviewing the spec, in all cases where the user agent instantiates a PresentationConnection, it sets both the URL and the ID before returning it to the caller. So it makes more sense to make both PresentationConnection.id and PresentationConnection.url mandatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment