/coreclr

Review Feedback. Standardize on _echo name #7532

Merged
merged 1 commit into from Oct 8, 2016
+16 −16

Reviewers

@jkotas jkotas

Assignees

No one assigned

Labels

cla-already-signed

Projects

None yet

Milestone

No milestone

3 participants

@vancem @jkotas @dnfclas
@vancem
Member
vancem commented Oct 8, 2016

This is a continuation of pull request #7528.

We decided to standardize on the _echo as the variable to turn on .CMD logging.

I will also review CoreFX, but that is a separate pull request
@vancem vancem Review Feedback. Standardize on _echo name

Some checks were not successful

2 failing and 10 successful checks
CentOS7.1 x64 Debug Build and Test — Build finished.
Details
Ubuntu x64 Checked Build and Test — Build finished.
Details
FreeBSD x64 Checked Build — Build finished.
Details
Linux ARM Emulator Cross Debug Build — Build finished.
Details
Linux ARM Emulator Cross Release Build — Build finished.
Details
OSX x64 Checked Build and Test — Build finished.
Details
Ubuntu x64 Formatting — Build finished.
Details
Windows_NT x64 Debug Build and Test — Build finished.
Details
Windows_NT x64 Formatting — Build finished.
Details
Windows_NT x64 Release Priority 1 Build and Test — Build finished.
Details
Windows_NT x86 legacy_backend Checked Build and Test — Build finished.
Details
Windows_NT x86 ryujit Checked Build and Test — Build finished.
Details
0cea014
@jkotas
jkotas approved these changes Oct 8, 2016 View changes
@jkotas jkotas merged commit 5f2aa3a into dotnet:master Oct 8, 2016
10 of 12 checks passed

10 of 12 checks passed

CentOS7.1 x64 Debug Build and Test Build finished.
Details
Ubuntu x64 Checked Build and Test Build finished.
Details
FreeBSD x64 Checked Build Build finished.
Details
Linux ARM Emulator Cross Debug Build Build finished.
Details
Linux ARM Emulator Cross Release Build Build finished.
Details
OSX x64 Checked Build and Test Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
Windows_NT x64 Debug Build and Test Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x64 Release Priority 1 Build and Test Build finished.
Details
Windows_NT x86 legacy_backend Checked Build and Test Build finished.
Details
Windows_NT x86 ryujit Checked Build and Test Build finished.
Details
@sergign60 sergign60 added a commit to sergign60/coreclr that referenced this pull request Nov 14, 2016
@vancem @sergign60 vancem + sergign60 Standardize on _echo name (#7532) 1fbfbe9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment