/bootstrap

Browse files

Bootstrap v3 does not currently claim to be compatible with jQuery v3… 

…; closes #16834

[skip sauce]
[skip validator]
1 parent ef1ce9a commit 9b1a213cf758e1b60e20c59a721a63e13da098f7 @cvrebert cvrebert committed Jul 27, 2015
Unified Split
Showing with 3 additions and 3 deletions.
  1. +1 −1 bower.json
  2. +2 −2 grunt/configBridge.json
View
2 bower.json
@@ -29,6 +29,6 @@
"test-infra"
],
"dependencies": {
- "jquery": ">= 1.9.1"
+ "jquery": "1.9.1 - 2"
}
}
View
4 grunt/configBridge.json
@@ -37,8 +37,8 @@
"+function ($) {",
" 'use strict';",
" var version = $.fn.jquery.split(' ')[0].split('.')",
- " if ((version[0] < 2 && version[1] < 9) || (version[0] == 1 && version[1] == 9 && version[2] < 1)) {",
- " throw new Error('Bootstrap\\'s JavaScript requires jQuery version 1.9.1 or higher')",
+ " if ((version[0] < 2 && version[1] < 9) || (version[0] == 1 && version[1] == 9 && version[2] < 1) || (version[0] > 2)) {",
+ " throw new Error('Bootstrap\\'s JavaScript requires jQuery version 1.9.1 or higher, but lower than version 3')",
" }",
"}(jQuery);\n\n"
]

9 comments on commit 9b1a213

@lynicidn
lynicidn commented on 9b1a213 Jul 28, 2015

revert this pr - it break composer (bower) dependencies

Adding VCS repository bower-asset/bootstrap

[UnexpectedValueException]

Could not parse version constraint <=2.: Invalid version string "2."

@lynicidn
lynicidn commented on 9b1a213 Jul 28, 2015

yiisoft/yii2#9231

@cvrebert
Bootstrap member
cvrebert commented on 9b1a213 Jul 28, 2015

@lynicidn bower install 'bootstrap#master' still works fine. Sounds like there's a bug in the non-Bower tools you're using. Also, you might as well just use the native composer package if you're using composer.

@lynicidn
lynicidn commented on 9b1a213 Jul 28, 2015

thanks for answer. Yii use bower via https://packagist.org/packages/fxp/composer-asset-plugin

but problem <=2 - it fine? may be need >=2 ?

@lynicidn
lynicidn commented on 9b1a213 Jul 28, 2015

or try write 2.0 or 2.*

@lynicidn
lynicidn commented on 9b1a213 Jul 28, 2015

look it https://getcomposer.org/doc/articles/versions.md#range
i think, here 9b1a213#diff-0a08a7565aba4405282251491979bb6bR32
need change to "jquery": "1.9.1 - 2.0"

@cvrebert
Bootstrap member
cvrebert commented on 9b1a213 Jul 28, 2015

@lynicidn fxpio/composer-asset-plugin#129

@lynicidn
lynicidn commented on 9b1a213 Jul 28, 2015

@cvrebert thx

@cvrebert
Bootstrap member
cvrebert commented on 9b1a213 Jul 29, 2015

For posterity:
Composer Asset Plugin has fixed their bug via fxpio/composer-asset-plugin#137

Please sign in to comment.