list_files() function bug

[Tkama]

If we set first parameter of list_files( $folder ) with trailing slash, we get incorrect paths in result. Example:

<?php
$files = list_files( ABSPATH );

print_r( $files );

/*
Array
(
    [0] => /home/t/tkamab32/wp-kama.ru/public_html//xmlrpc.php
    [1] => /home/t/tkamab32/wp-kama.ru/public_html//wp-mail.php
    [2] => /home/t/tkamab32/wp-kama.ru/public_html//wp-includes/ms-settings.php
    ...
*/

We see double slash // in path...

Maybe better to filter incoming $folder parametr with untrailingslashit():

<?php
function list_files( $folder = '', $levels = 100 ) {
    if ( empty($folder) )
        return false;

    $folder = untrailingslashit( $folder );

    ...

Created .diff

Created a diff as the original author proposed for easier access & testing.

I also run some tests with various folder configurations without seeing any problems. So probably it's good to go as well.

Best regards,
Konstantinos

Patch with unit tests

I've added another patch with some pretty simple unit tests for this.