LEGACY_GL_EMULATION generate wrong shaders #4884
|
Ok, I found where problem is. If I comment this, then error is disappeared:
|
|
I didn't write the texenv stuff myself, not sure what's going wrong there. But since you found the relevant code, and it's not that long, we should be able to figure it out. If you get stuck, maybe try to make a reduced testcase and I can take a look. |
|
By first glance, this seems to be somehow caused by nested parentheses in regex searches. Iirc regexes have difficult time in matching nesting levels. Perhaps it might be possible to optimise the regexes to detect and at least not kick in when this type of scenario occurs. |
|
I can prepare test case and maybe some fix. Since my projects work fine it is not critical. So, I plan do this on the next week when I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! I am porting new project, that uses legacy opengl. For now, I can`t see anything in game because LEGACY_GL_EMULATION produces wrong shaders, like this:
In this shader parentheses are not balanced (for example on line 13). May be I can fix by my self, but I don`t have good understanding of LEGACY_GL_EMULATION implementation yet.
branch: incoming
os: ubuntu