Sign upLogin

otwcode/otwarchive

View on GitHub
Star

AO3-4971 Display notice when deleting non-existent invite requests
#3159

16997743
redsummernight wants to merge redsummernight:AO3-4971-redirect into otwcode:master
Compare on GitHub
Failed
1 issue to fix.

Method destroy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
New

  def destroy
    @invite_request = InviteRequest.find_by(params[:id])
    if @invite_request.nil? || @invite_request.destroy
      success_message = if @invite_request.nil?
                          ts("Request was removed from the queue.")
Severity: Minor
Found in app/controllers/invite_requests_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status

No ratings changes.