Sign upLogin

otwcode/otwarchive

View on GitHub
Star

AO3-5243 Use AJAX to delete invitation requests
#3151

907055
sarken wants to merge sarken:AO3-5243 into otwcode:master
Compare on GitHub
Failed
1 issue to fix.

Complex method in #destroy
New

  def destroy
    @invite_request = InviteRequest.find(params[:id])
    if @invite_request.destroy
      success_message = ts("Request for %{email} was removed from the queue.", email: @invite_request.email)
      respond_to do |format|
Found in InviteRequestsController - About 4 hrs to fix

Long or complex methods can make code harder to understand. In most circumstances, methods are best as a small chunk of code (the "how") with a clear, understandable name (the "what"). Long methods can also lead to duplication, as it's harder to reuse logic that is tightly coupled to surrounding code.

Refactorings

Read More

There are no issues that match your filters.

Category
FileMaintainability
script/seed_dump.rb
A
0 mins
lib/autocomplete_source.rb
D
A
-1 day
app/controllers/collection_items_controller.rb
C
A
-1 day
app/controllers/application_controller.rb
D
A
-2 days
app/controllers/owned_tag_sets_controller.rb
C
A
-1 day
app/models/bookmark_search.rb
D
A
-3 days
app/controllers/admin/skins_controller.rb
D
A
-1 day
app/helpers/comments_helper.rb
C
A
-1 day
lib/taggable.rb
B
A
-6 hrs
lib/css_cleaner.rb
D
A
-1 day
app/models/comment.rb
F
A
-3 days
app/controllers/bookmarks_controller.rb
D
A
-2 days
app/models/story_parser.rb
F
A
-5 days
app/models/challenge_signup.rb
D
A
-2 days
app/models/potential_match.rb
B
A
-5 hrs
app/models/prompt.rb
D
A
-2 days
app/controllers/tag_set_nominations_controller.rb
F
A
-3 days
app/controllers/collection_participants_controller.rb
C
A
-7 hrs
app/controllers/chapters_controller.rb
D
A
-2 days
app/models/user.rb
D
A
-2 days
app/models/pseud.rb
D
A
-2 days
app/controllers/admin/admin_users_controller.rb
D
A
-1 day
app/models/search_result.rb
B
A
-5 hrs
app/helpers/application_helper.rb
F
A
-3 days
lib/logfile_reader.rb
B
A
-4 hrs
app/controllers/challenge_claims_controller.rb
B
A
-5 hrs
app/controllers/series_controller.rb
B
A
-6 hrs
app/models/work_search.rb
F
A
-3 days
app/controllers/skins_controller.rb
C
A
-1 day
app/controllers/kudos_controller.rb
B
A
-4 hrs
app/controllers/tag_wranglers_controller.rb
C
A
-1 day
app/models/tagset_models/tag_set.rb
C
A
-1 day
app/controllers/tag_wranglings_controller.rb
C
A
-1 day
app/controllers/user_sessions_controller.rb
C
A
-1 day
app/models/work.rb
F
A
-1 wk
app/models/collection_item.rb
D
A
-1 day
app/controllers/users_controller.rb
D
A
-2 days
app/mailers/user_mailer.rb
D
A
-2 days
app/helpers/translation_helper.rb
C
A
-7 hrs
app/models/challenge_assignment.rb
F
A
-3 days
lib/skin_wizard.rb
C
A
-1 day
app/controllers/pseuds_controller.rb
B
A
-5 hrs
app/helpers/users_helper.rb
B
A
-4 hrs
app/models/tag.rb
F
A
-1 wk
app/models/tagset_models/owned_tag_set.rb
C
A
-1 day
app/controllers/challenge_signups_controller.rb
D
A
-2 days
app/models/bookmark.rb
C
A
-1 day
app/controllers/gifts_controller.rb
B
A
-5 hrs
app/helpers/prompt_restrictions_helper.rb
B
A
-5 hrs
app/models/series.rb
C
A
-7 hrs
app/models/skin.rb
F
A
-3 days
app/helpers/tag_sets_helper.rb
B
A
-5 hrs
app/controllers/tags_controller.rb
F
A
-3 days
app/mailers/kudo_mailer.rb
B
A
-4 hrs
features/support/paths.rb
C
A
-1 day
lib/creatable.rb
B
A
-6 hrs
app/controllers/collections_controller.rb
B
A
-4 hrs
features/step_definitions/web_steps.rb
B
A
-4 hrs
app/controllers/challenge_assignments_controller.rb
C
A
-1 day
app/helpers/tags_helper.rb
D
A
-2 days
app/controllers/stats_controller.rb
C
A
-7 hrs
app/models/collection.rb
D
A
-2 days
spec/helpers/works_helper_spec.rb
A
config/initializers/authlogic.rb
A
spec/controllers/works/default_rails_actions_spec.rb
C
features/step_definitions/email_custom_steps.rb
A
config/initializers/archive_config/time_formats.rb
A
config/initializers/gem-plugin_config/webmock.rb
A
public/javascripts/jquery.timeago.min.js
A
public/javascripts/jquery-ui.min.js
A
config/initializers/copycopter.rb
A
spec/models/index_queue_spec.rb
A
public/javascripts/tinymce/plugins/save/plugin.min.js
A
public/javascripts/tinymce/plugins/autoresize/plugin.min.js
A
db/migrate/20171030201300_add_simplified_email_to_invite_requests.rb
A
features/step_definitions/tag_set_steps.rb
A
public/javascripts/jquery.min.js
A
features/step_definitions/archivist_steps.rb
A
public/javascripts/jquery-shuffle.js
A
spec/helpers/tag_sets_helper_spec.rb
A
config/initializers/filter_parameter_logging.rb
A
config/environment.rb
A
spec/lib/string_cleaner_spec.rb
A
spec/lib/collectible_spec.rb
A
config/initializers/mime_types.rb
A
spec/controllers/tag_set_associations_controller_spec.rb
A
config/initializers/gem-plugin_config/acts_as_commentable.rb
A
db/migrate/20141127004302_create_fannish_next_of_kins.rb
A
public/javascripts/jquery.livequery.min.js
A
features/step_definitions/series_steps.rb
A
config/deploy/staging.rb
A
public/javascripts/tinymce/plugins/colorpicker/plugin.min.js
A
spec/controllers/chapters_controller_spec.rb
F
db/migrate/20170615090455_remove_admin_emails_off_from_preferences.rb
A
features/support/sphinx.rb
A
features/step_definitions/comment_steps.rb
A
spec/models/admin_spec.rb
A
spec/models/potential_match_spec.rb
A
public/javascripts/tinymce/plugins/tabfocus/plugin.min.js
A
spec/api/api_base_controller_spec.rb
A
public/javascripts/tinymce/plugins/charmap/plugin.min.js
A
factories/abuse_reports.rb
A
public/javascripts/filters.js
A
public/javascripts/jquery.js
F
db/migrate/20150901132832_add_unreviewed_to_comments.rb
A
public/javascripts/tinymce/plugins/hr/plugin.min.js
A
spec/support/matchers/be_valid_verbose.rb
A
factories/tags.rb
A
features/step_definitions/fixtures_steps.rb
A
spec/helpers/exports_helper_spec.rb
A
features/step_definitions/bookmark_steps.rb
A
spec/controllers/autocomplete_controller_spec.rb
A
config/initializers/wrap_parameters.rb
A
spec/models/work_search_spec.rb
B
config/initializers/rollout_init.rb
A
public/javascripts/rails.js
D
config/environments/staging.rb
A
public/javascripts/livevalidation_standalone.js
F
config/routes.rb
C
factories/kudos.rb
A
features/step_definitions/challenge_steps.rb
A
config/schedule_web.rb
A
features/step_definitions/work_steps.rb
C
config/deploy/production.rb
A
public/javascripts/tinymce/plugins/textpattern/plugin.min.js
A
public/javascripts/jquery.qtip.min.js
A
features/support/database_cleaner.rb
A
spec/models/story_parser_spec.rb
A
public/javascripts/tinymce/plugins/paste/plugin.min.js
A
features/step_definitions/skin_steps.rb
A
config/initializers/archive_config/archive_config.rb
A
spec/controllers/collection_profile_controller_spec.rb
A
config/initializers/gem-plugin_config/will_paginate_config.rb
A
features/step_definitions/kudos_steps.rb
A
spec/models/tag_spec.rb
C
config/environments/development.rb
A
public/javascripts/tinymce/plugins/code/plugin.min.js
A
features/support/vcr.rb
A
db/migrate/20170321202522_add_index_to_tag_nominations.rb
A
public/javascripts/tinymce/plugins/table/plugin.min.js
A
config/initializers/inflections.rb
A
public/javascripts/tinymce/plugins/image/plugin.min.js
A
config/deploy.rb
A
features/support/pickle.rb
A
public/javascripts/mce_editor.js
B
config/initializers/backtrace_silencers.rb
A
config/initializers/new_framework_defaults.rb
A
db/migrate/20170414154143_add_request_uuid_to_audits.rb
A
config/initializers/session_store.rb
A
config/initializers/assets.rb
A
public/javascripts/tinymce/plugins/insertdatetime/plugin.min.js
A
config/initializers/gem-plugin_config/phusion_passenger_config.rb
A
spec/controllers/prompt_meme_controller_spec.rb
A
config/initializers/gem-plugin_config/resque_mailer.rb
A
config/initializers/gem-plugin_config/newrelic.rb
A
factories/wrangling_guideline.rb
A
spec/models/spam_report_spec.rb
A
config/initializers/gem-plugin_config/tire.rb
A
spec/controllers/works/multiple_actions_spec.rb
A
config/initializers/gem-plugin_config/elasticsearch.rb
A
config/initializers/devise.rb
A
config/schedule_production.rb
A
config/environments/test.rb
A
spec/api/api_helper.rb
A
features/step_definitions/icon_steps.rb
A
spec/models/challenge_assignment_spec.rb
A
spec/models/user_invitation_spec.rb
A
public/javascripts/tinymce/plugins/searchreplace/plugin.min.js
A
public/javascripts/tinymce/plugins/nonbreaking/plugin.min.js
A
spec/controllers/external_authors_controller_spec.rb
A
public/javascripts/tinymce/plugins/example/plugin.min.js
A
public/javascripts/jquery-ui.js
F
spec/models/user_spec.rb
A
config/environments/production.rb
A
spec/helpers/home_helper_spec.rb
A
config/initializers/cookies_serializer.rb
A
spec/models/collection_spec.rb
A
public/javascripts/tinymce/plugins/link/plugin.min.js
A
public/javascripts/filters.min.js
A
spec/models/chapter_spec.rb
A
config/initializers/phraseapp_in_context_editor.rb
A
spec/models/external_work_spec.rb
A
public/javascripts/select_all.js
B
config/locales/fun/gibberish.rb
A
public/javascripts/mce_editor.min.js
A
features/step_definitions/preferences_steps.rb
A
spec/api/api_bookmarks_spec.rb
A
db/migrate/20160706031054_move_admins_to_devise.rb
A
features/step_definitions/challenge_promptmeme_steps.rb
C
spec/api/api_works_spec.rb
C
spec/spec_helper.rb
A
spec/mailers/abuse_mailer_spec.rb
A
db/migrate/20170919143944_add_indexes_to_nominations.rb
A
spec/mailers/collection_mailer_spec.rb
A
spec/helpers/user_invite_requests_helper_spec.rb
A
spec/helpers/inbox_helper_spec.rb
A
spec/helpers/share_helper_spec.rb
A
spec/models/locale_spec.rb
A
spec/controllers/challenge_claims_controller_spec.rb
A
public/javascripts/jquery.tokeninput.js
F
spec/controllers/challenge_signups_controller_spec.rb
A
spec/controllers/wrangling_guidelines_controller_spec.rb
A
spec/controllers/owned_tag_sets_controller_spec.rb
B
spec/controllers/collection_items_controller_spec.rb
B
spec/models/abuse_report_spec.rb
A
public/javascripts/tinymce/plugins/importcss/plugin.min.js
A
features/step_definitions/work_import_steps.rb
A
spec/controllers/related_works_controller_spec.rb
A
spec/models/admin_blacklisted_email_spec.rb
A
public/javascripts/tinymce/plugins/advlist/plugin.min.js
A
spec/controllers/inbox_controller_spec.rb
A
spec/controllers/challenges_controller_spec.rb
A
config/initializers/transaction_retry.rb
A
spec/models/index_subqueue_spec.rb
A
spec/controllers/collection_participants_controller_spec.rb
C
spec/controllers/prompts_controller_spec.rb
A
spec/controllers/comments_controller_spec.rb
D
spec/support/login_macros.rb
A
spec/controllers/works/miscellaneous_spec.rb
A
spec/controllers/works/drafts_spec.rb
A
spec/controllers/works/importing_spec.rb
A
spec/support/redirect_expectation_helper.rb
A
config/initializers/application_controller_renderer.rb
A
spec/models/invite_request_spec.rb
A
config/initializers/resque_mailer.rb
A
spec/models/cache_master_spec.rb
A
spec/models/invitation_spec.rb
A
spec/models/stat_counter_spec.rb
A
spec/models/gift_spec.rb
A
factories/series.rb
A
spec/models/tag_set_nomination_spec.rb
A
public/javascripts/bootstrap/bootstrap-dropdown.js
A
spec/models/pseud_spec.rb
A
public/javascripts/tinymce/plugins/autosave/plugin.min.js
A
spec/lib/xhtml_splitter_spec.rb
A
spec/lib/html_cleaner_spec.rb
F
spec/lib/tasks/resque.rake_spec.rb
A
public/dispatch.rb
A
spec/models/gift_exchange_spec.rb
A
public/javascripts/jquery.scrollTo.js
A
public/javascripts/jquery.purr.js
C
public/javascripts/jquery.timeago.js
A
factories/challenge_claims.rb
A
public/javascripts/jquery.cookie.js
A
public/javascripts/jquery.scrollTo.min.js
A
public/javascripts/ao3modal.js
D
public/javascripts/unittest.js
F
public/javascripts/tinymce/plugins/autolink/plugin.min.js
A
public/javascripts/tinymce/plugins/visualblocks/plugin.min.js
A
public/javascripts/jquery.intoViewport.min.js
A
public/javascripts/tinymce/plugins/directionality/plugin.min.js
A
public/javascripts/tinymce/plugins/wordcount/plugin.min.js
A
public/javascripts/tinymce/plugins/emoticons/plugin.min.js
A
public/javascripts/tinymce/plugins/bbcode/plugin.min.js
A
public/javascripts/tinymce/plugins/fullpage/plugin.min.js
A
public/javascripts/tinymce/plugins/print/plugin.min.js
A
spec/lib/works_owner_spec.rb
A
public/javascripts/tinymce/plugins/lists/plugin.min.js
A
public/javascripts/tinymce/plugins/textcolor/plugin.min.js
A
public/javascripts/tinymce/plugins/codesample/plugin.min.js
A
config/boot.rb
A
public/javascripts/tinymce/plugins/pagebreak/plugin.min.js
A
factories/prompt_restriction.rb
A
config/initializers/gem-plugin_config/livevalidation.rb
A
spec/controllers/users_controller_spec.rb
A
spec/controllers/admin_posts_controller_spec.rb
A
public/javascripts/jquery.tokeninput.min.js
A
public/javascripts/tinymce/plugins/example_dependency/plugin.min.js
A
public/javascripts/tinymce/plugins/preview/plugin.min.js
A
config/schedule.rb
A
public/javascripts/tinymce/tinymce.min.js
A
features/step_definitions/invite_steps.rb
A
public/javascripts/translation_status.js
A
spec/controllers/challenge_assignments_controller_spec.rb
A
public/javascripts/tinymce/themes/modern/theme.min.js
A
public/javascripts/application.js
F
public/javascripts/jquery-ui-timepicker-addon.js
A
public/javascripts/tinymce/plugins/imagetools/plugin.min.js
A
spec/controllers/bookmarks_controller_spec.rb
A
spec/lib/logfile_reader_spec.rb
A
config/initializers/archive_config/settings_for_admin.rb
A
spec/controllers/profile_controller_spec.rb
A
spec/lib/url_formatter_spec.rb
A
factories/prompt.rb
A
public/javascripts/tinymce/plugins/fullscreen/plugin.min.js
A
config/initializers/gem-plugin_config/redis.rb
A
factories/bookmarks.rb
A
factories/subscriptions.rb
A
db/migrate/20141003204623_add_interface_enabled_to_locale.rb
A
spec/models/series_spec.rb
A
factories/invitations.rb
A
features/step_definitions/page_title_steps.rb
A
features/step_definitions/pickle_steps.rb
A
db/migrate/20151129234505_add_rejected_to_gifts.rb
A
spec/models/skin_parent_spec.rb
A
spec/models/subscription_spec.rb
A
public/javascripts/tinymce/plugins/anchor/plugin.min.js
A
public/javascripts/tinymce/plugins/template/plugin.min.js
A
spec/controllers/serial_works_controller_spec.rb
A
config/initializers/archive_config/locale.rb
A
features/support/minitest.rb
A
features/support/factories.rb
A
public/javascripts/builder.js
C
spec/api/api_authorization_spec.rb
A
factories/pseuds.rb
A
features/support/hooks.rb
A
app/controllers/works_controller.rb
F
public/javascripts/sound.js
A
features/step_definitions/request_header_steps.rb
A
public/javascripts/bootstrap/bootstrap-dropdown.min.js
A
lib/html_cleaner.rb
D
features/step_definitions/orphan_steps.rb
A
factories/faq.rb
A
public/javascripts/tinymce/plugins/contextmenu/plugin.min.js
A
config/initializers/archive_config/mail.rb
A
factories/language.rb
A
db/migrate/20150901024743_add_moderated_commenting_enabled_to_works.rb
A
public/javascripts/tinymce/plugins/visualchars/plugin.min.js
A
factories/locales.rb
A
public/javascripts/tinymce/plugins/noneditable/plugin.min.js
A
features/step_definitions/tag_steps.rb
B
spec/models/skin_spec.rb
A
features/step_definitions/challege_gift_exchange_steps.rb
A
spec/models/external_author_spec.rb
A
db/migrate/20171030220348_add_index_to_invite_queue_emails.rb
A
db/migrate/20171006090901_add_index_to_preferences.rb
A
db/migrate/20141004123421_add_locale_to_preferences.rb
A
db/migrate/20170918172719_add_more_index_to_tag_nominations.rb
A
features/step_definitions/work_search_steps.rb
B
db/migrate/20170322092920_rename_taggings_count_to_taggings_count_cache.rb
A
db/migrate/20151018165632_add_support_available_to_languages.rb
A
factories/related_works.rb
A
factories/collections.rb
A
factories/admin_blacklisted_email.rb
A
factories/chapters.rb
A
factories/admin.rb
A
factories/comments.rb
A
spec/models/comment_spec.rb
A
factories/admin_post.rb
A
factories/user_invite_requests.rb
A
factories/serial_work.rb
A
public/javascripts/tinymce/plugins/layer/plugin.min.js
A
features/step_definitions/email_steps.rb
A
factories/challenges.rb
A
factories/skins.rb
A
spec/controllers/tag_set_nominations_controller_spec.rb
F
spec/controllers/gift_exchange_controller_spec.rb
A
spec/mailers/comment_mailer_spec.rb
A
db/migrate/20160416163754_add_is_translated_check_to_questions.rb
A
features/step_definitions/work_deletion_steps.rb
A
spec/helpers/validation_helper_spec.rb
A
spec/controllers/external_works_controller_spec.rb
A
db/migrate/20170331170222_change_readings_id_type.rb
A
public/javascripts/tinymce/plugins/legacyoutput/plugin.min.js
A
public/javascripts/slider.js
D
features/step_definitions/challenge_yuletide_steps.rb
A
features/step_definitions/pseud_steps.rb
A
features/step_definitions/profile_steps.rb
A
factories/api_key.rb
A
factories/users.rb
A
features/step_definitions/autocomplete_steps.rb
A
features/step_definitions/admin_steps.rb
B
features/step_definitions/user_steps.rb
A
features/step_definitions/search_steps.rb
A
factories/feedback.rb
A
features/step_definitions/external_work_steps.rb
A
spec/support/mailer_macros.rb
A
features/step_definitions/banner_steps.rb
A
features/step_definitions/generic_steps.rb
A
spec/requests/comments_spec.rb
A
features/step_definitions/gift_steps.rb
A
features/step_definitions/work_related_steps.rb
A
public/javascripts/jquery.trap.min.js
A
public/javascripts/ao3modal.min.js
A
db/migrate/20160331005706_create_admin_blacklisted_emails.rb
A
features/step_definitions/redis_mail_queue_steps.rb
A
features/support/webmock.rb
A
spec/lib/autocomplete_source_spec.rb
A
spec/controllers/tags_controller_spec.rb
A
features/support/env.rb
A
app/controllers/comments_controller.rb
F
features/step_definitions/subscription_steps.rb
A
spec/mailers/feedback_mailer_spec.rb
A
spec/lib/word_counter_spec.rb
A
spec/models/unsorted_tag_spec.rb
A
features/step_definitions/potential_match_steps.rb
A
public/javascripts/tinymce/plugins/media/plugin.min.js
A
factories/works.rb
A
features/step_definitions/reading_steps.rb
A
spec/mailers/user_mailer_spec.rb
A
config/locales/fun/en-AU.rb
A
spec/models/challenge_claim_spec.rb
A
config/deploy/i18n.rb
A
spec/controllers/admin/api_controller_spec.rb
A
public/javascripts/tinymce/plugins/spellchecker/plugin.min.js
A
spec/controllers/invite_requests_controller_spec.rb
A
config/initializers/gem-plugin_config/resque.rb
A
spec/controllers/series_controller_spec.rb
A
features/step_definitions/collection_steps.rb
A
db/migrate/20150725141326_install_audited.rb
A
spec/controllers/opendoors/tools_controller_spec.rb
A
db/schema.rb
F
db/migrate/20141003205439_add_email_enabled_to_locale.rb
A
spec/controllers/locales_controller_spec.rb
A
spec/models/work_spec.rb
A
app/validators/email_veracity_validator.rb
A