Comment 1 Ahmed Soliman 2011-08-11 08:09:06 PDT

+1 to the priority of this, I would love to see this implemented so that we can have 613149 fixed

Comment 2 Simon Montagu :smontagu 2011-08-30 07:42:46 PDT

Created attachment 556835 [details] [diff] [review]
Patch

Comment 3 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-08-30 12:01:09 PDT

Comment on attachment 556835 [details] [diff] [review]
Patch

Review of attachment 556835 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsBlockFrame.cpp
@@ +3567,5 @@
> +  // frame, because the block frame could be split by hard line breaks into
> +  // multiple paragraphs with different base direction
> +  FramePropertyTable *propTable = aState.mPresContext->PropertyTable();
> +  PRUint8 direction = PRUint32(propTable->Get(aLine->mFirstChild,
> +                                              BaseLevelProperty())) & 1;

Can we store this direction in a state bit so we don't have to do a mildly-expensive property get here?

Or condition this on bidi being enabled?

Comment 4 Simon Montagu :smontagu 2011-08-30 15:27:36 PDT

Created attachment 557016 [details] [diff] [review]
Patch v.2

Howzabouts if we move the test on unicode-bidi: plaintext out of BeginLineReflow to the callers, like so?

Comment 5 Simon Montagu :smontagu 2011-10-18 08:25:28 PDT

https://hg.mozilla.org/integration/mozilla-inbound/rev/388df914497e

Comment 6 Marco Bonardo [::mak] 2011-10-19 03:07:06 PDT

https://hg.mozilla.org/mozilla-central/rev/388df914497e

Comment 7 Jean-Yves Perrier [:teoli] 2011-11-21 05:22:54 PST

I've updated:
https://developer.mozilla.org/en/CSS/unicode-bidi
https://developer.mozilla.org/en/Firefox_10_for_developers