Last Comment Bug 616402 - block margins should be ignored at a page break
: block margins should be ignored at a page break
Status: NEW
: css2, testcase
Product: Core
Classification: Components
Component: Layout: Block and Inline (show other bugs)
: Trunk
: All All
: -- normal with 2 votes (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
http://test.csswg.org/suites/css2.1/l...
Depends on:
Blocks: css2.1-tests css3-break 616345
  Show dependency tree / graph
 
Reported: 2010-12-02 22:36 PST by David Baron :dbaron: ⌚️UTC+2 (review requests must explain patch) (vacation June 4-12)
Modified: 2013-06-26 20:40 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Baron :dbaron: ⌚️UTC+2 (review requests must explain patch) (vacation June 4-12) 2010-12-02 22:36:17 PST 
According to CSS 2.1, section 13.3.3:

# ... page breaks can occur ...
#
# 1. In the vertical margin between block boxes. When an unforced page break
# occurs here, the used values of the relevant 'margin-top' and 'margin-bottom'
# properties are set to '0'. When a forced page break occurs here, the used
# value of the relevant 'margin-bottom' property is set to '0'; the relevant
# 'margin-top' used value may either be set to '0' or retained.

We don't implement this setting of the margins to zero.  This causes us to fail:

http://test.csswg.org/suites/css2.1/20100917/html4/page-break-margins-002.htm
Comment 1 David Baron :dbaron: ⌚️UTC+2 (review requests must explain patch) (vacation June 4-12) 2010-12-02 22:38:42 PST 
and also:
http://test.csswg.org/suites/css2.1/20100917/html4/page-break-margins-004.htm
Comment 2 Alex Angas 2012-12-01 21:27:24 PST 
Test links in previous comments are broken and can now be found here:

http://test.csswg.org/suites/css2.1/latest/html4/page-break-margins-002.htm
http://test.csswg.org/suites/css2.1/latest/html4/page-break-margins-004.htm
Comment 3 Gérard Talbot 2013-06-24 16:01:30 PDT 
Hello,

Regarding 

http://test.csswg.org/suites/css2.1/latest/html4/page-break-margins-004.htm
(and only such test)

I get expected results (both in print preview and in printed pages) with Firefox 21 (build ID: 20130512193902), under Linux KDE 4.10.4 (Kubuntu 13.04), i686 (32bits): 2 pages of output and other test requirements are honored, are met.
Comment 4 fantasai 2013-06-26 12:11:45 PDT 
Gérard, did you make sure that the background-printing option is on? It is disabled by default. (You can find it in the Options tab of the print dialog.) Without background printing on, the yellow check isn't accurate. (Without it on... you'd have to make sure the sentence on the second page is really at the top of the page, not 1in down.)
Comment 5 Gérard Talbot 2013-06-26 20:40:28 PDT 
> Gérard, did you make sure that the background-printing option is on? It is
> disabled by default. (You can find it in the Options tab of the print
> dialog.) Without background printing on, the yellow check isn't accurate.

Ok, I see. You're right. I mishandled this.

There is a yellow band of 1in tall on the second page.

> (Without it on... you'd have to make sure the sentence on the second page is
> really at the top of the page, not 1in down.)

Ok. Sorry about that. So, this test is *not* passed yet and I'm using Firefox 22.

Gérard
Note You need to log in before you can comment on or make changes to this bug.