Comparing changes
Open a pull request
|
sparecycles |
variadic arguments breaking out of scope (test)
|
2dc2d16
|
|
|
sparecycles |
Fixed splat sibling variable scope leak.
|
6d27334
|
|||
|
|
sparecycles |
Removed extra index variable left from code thrash
|
d11d699
|
|||
|
|
sparecycles |
fixed 2nd scoping problem
x = 10 ([x]) -> # used to not declare var x this is one fix, the other way to fix it is to remove the entire if ... olen is 1 .... block... not sure if that's a good idea or not. |
1809c0e
|
|||
|
|
sparecycles |
fixed name of simple destructuring test.
|
dc49908
|
|
geraldalewis |
Fix for #1216 ?= compilation
|
2212e95
|
|
jashkenas |
Merge pull request #1324 from TrevorBurnham/node-modules
Use `require.main` instead of loop to get main module |
01b0cfc
|
|||
|
|
sparecycles |
removing unimportant changes for easy pull.
|
395a97e
|
|||
|
|
jashkenas |
Merge pull request #1346 from adam-f/fixedsplatscope
Fixed improper scoping of siblings to the splat argument. |
004f13f
|
|||
|
michaelficarra |
cleaned up and optimized fix for #1354 (d91ccd4)
|
2ac7435
|
|||
|
fjakobs |
fix line numbers after heregexps
|
abb11a7
|
|
|
michaelficarra |
merging in @fjakobs's heregex line number fix; closes #1374
|
19520d8
|
|
|
michaelficarra |
test for #1380
|
8e5eff5
|
|||
|
|
michaelficarra |
fixes #1380: `super` with reserved names
|
bbf1c6a
|
|||
|
|
michaelficarra |
fixes #1390: persistence of non-enumerable global properties in the REPL
|
454aa84
|
|||
|
|
michaelficarra |
Merge pull request #1388 from johnyanarella/master
'coffee' silently fails with no output when the --join option is specified and the source files specified include directories |
bbf37e5
|
|||
|
|
michaelficarra |
merging @TrevorBurnham's pull request #1314, enhancing `CS.eval`; clo…
…ses #1314 |
e4f47a0
|
|||
|
|
michaelficarra |
enhancement for #1380 fix
|
042f7ec
|
|||
|
|
michaelficarra |
removing accidentally-committed `console.log`
|
94fb7e3
|
|||
|
|
michaelficarra |
hopefully the last enhancement for my #1380 fix
|
085874d
|
|
|
jashkenas |
Revert "__bind helper: caching ctor"
This reverts commit 9cbf2a8. |
79fff36
|
|||
|
|
jashkenas |
Revert "switched to canonical two-space indentation in __bind helper"
This reverts commit 6a40807. |
7082000
|
|||
|
|
jashkenas |
Revert "fixed condext during construction of bound functions; now usi…
…ng native" This reverts commit 8d6e33c. |
1fb34e4
|
|
|
michaelficarra |
fixes #1398: comments in the REPL
|
10ec1a6
|
|
|
michaelficarra |
fixes #1420: `(fn() ->)` by causing the `Lexer::tagParameters` method to
give up looking for a parameter list when it saw a `CALL_START` token. |
522f2ee
|
|||
|
|
michaelficarra |
adding regression test for #1420; also cleaned up a little trailing
whitespace in the function invocation tests |
dfcff3f
|
|
|
michaelficarra |
subliminally promoting the use of interpolation in the documentation
|
47f12c4
|
|
ngn |
Fix for #1150: String interpolation regression
|
0f523de
|
|
thejh |
added a test for #1436, `for` etc. should work as normal property names
|
9941c3f
|
|||
|
|
thejh |
fixed #1436
|
9699059
|
|||
|
|
ngn |
Another attempt to fix #1150
Here's how the algorithm in balancedString() was modified. When we
encounter a slash in an interpolation, we:
* try to find a heregex right after it; if found---skip it. Three
slashes always terminate a heregex, no matter if there is an open
"#{" before them or not, so we don't have to bother about
sub-interpolations inside the heregex.
* try to find a regex right after it; if found---skip it. Simple
regexen can't contain interpolations.
* otherwise, assume that the slash means division and carry on. |
5ce7984
|
|
|
thejh |
test for #1416: don't omit one 'new' when compiling 'new new'
|
11f2cd4
|
|||
|
|
thejh |
fixes #1416: don't omit one 'new' when compiling 'new new'
|
f0c22f3
|
|
|
thejh |
added another test for #1416
|
8b2884e
|
|||
|
|
thejh |
second part of fixing #1416
|
73af3b1
|
|
|
ngn |
added one more test for #1150
|
6f64fc2
|
|
yyyc514 |
compileJoin should happen once after all files are read
|
dc272a6
|
|||
|
|
yyyc514 |
combine conditions
|
cd65c66
|
|
Timothy Jones |
Fixes #1467. Catch now introduces its parameter to scope.
|
baa983a
|
|||
|
|
Timothy Jones |
Fixes #1461. Existential assignment now correctly reports if it is a …
…statement. |
e38aeef
|
|
|
Timothy Jones |
Fixes #1467. Catch now introduces its parameter to scope.
|
0f18dff
|
|||
|
|
Timothy Jones |
Fixes #1461. Existential assignment now correctly reports if it is a …
…statement. |
22cee5d
|
|
|
jashkenas |
fixes #1478, documentation.
|
2951d34
|
|||
|
|
jashkenas |
Merge branch 'master' of github.com:jashkenas/coffee-script
|
18ab569
|
|
|
michaelficarra |
fixes tab completion in the REPL
|
af1cf34
|
|
|
michaelficarra |
Added globals to the REPL that are (for a reason currently unknown to
me) not provided by `vm.Script.createContext` |
07baed8
|
|||
|
|
michaelficarra |
arranged and formatted nonContextGlobals list in REPL
|
cb8e147
|
|
|
jashkenas |
Merge pull request #1498 from breckinloggins/master
Some typo corrections and minor documentation edits |
1927213
|
|||
|
|
jashkenas |
Fixing funkiness introduced in #1498.
|
8fe59ed
|
|
|
jashkenas |
Merge pull request #1460 from yyyc514/fix_print_with_join
compileJoin should happen once after all files are read |
c2b32df
|
|||
|
|
jashkenas |
Merge pull request #1518 from taku0/fix_pluckDirectCall
Removed a garbage code in `pluckDirectCall`. |
7790df0
|
|||
|
|
jashkenas |
Merge pull request #1517 from breckinloggins/master
Patch for issue #1492 (consecutive semicolons in compiled output) |
813efbe
|
|||
|
|
michaelficarra |
improving test for #1492
|
8931e31
|
|||
|
breckinloggins |
Replacing heredoc in test with simple string
|
2b31f28
|
|
|
jashkenas |
Merge pull request #1522 from breckinloggins/fix_1470
Issue #1470: Command line compiler now assumes ".coffee" extension if left off of file names |
37019da
|
|||
|
|
breckinloggins |
Merge branch 'master' of git://github.com/jashkenas/coffee-script
|
5ee0254
|
|||
|
|
breckinloggins |
Fix for issue #1446: Compiler crashes on permissions error instead of…
… giving meaningful error message |
2d54fea
|
|||
|
|
jashkenas |
Merge pull request #1527 from breckinloggins/fix_1446
Fix for issue #1446: Compiler fails with unrelated exception on file permissions problems |
860c503
|
|||
|
|
michaelficarra |
Cakefile: build:full exits unsuccessfully when tests or builds fail;
test failures now print full stack trace |
d2d02bf
|
|
satyr |
fixed #1322; block comments no longer get out of implicitly called im…
…plicit objects |
9b9612e
|
|
|
michaelficarra |
changed uses of the `slice` method to CS slices in `nodes.coffee`
|
e7854be
|
|||
|
Mike Blume |
check existence of this.context. Avoid build error
#1541 with thanks to analyst74 whose bug report made the fix trivial =) |
178af9d
|
|
|
michaelficarra |
formatting and rewording a test
|
9f89a83
|
|
|
michaelficarra |
Merge pull request #1542 from MichaelBlume/master
Check for existence of this.context. Avoid build error. |
1f69200
|
|
|
jashkenas |
CoffeeScript 1.1.2
|
1a652a9
|
- +1 −1 .npmignore
- +26 −24 Cakefile
- +1 −1 documentation/coffee/aliases.coffee
- +1 −1 documentation/coffee/block_comment.coffee
- +1 −1 documentation/coffee/classes.coffee
- +1 −1 documentation/coffee/expressions_try.coffee
- +1 −1 documentation/coffee/object_comprehensions.coffee
- +1 −1 documentation/coffee/while.coffee
- +4 −0 documentation/css/docs.css
- +2 −2 documentation/docs/browser.html
- +1 −1 documentation/docs/cake.html
- +29 −20 documentation/docs/coffee-script.html
- +23 −5 documentation/docs/command.html
- +43 −45 documentation/docs/grammar.html
- +12 −6 documentation/docs/lexer.html
- +195 −160 documentation/docs/nodes.html
- +1 −1 documentation/docs/optparse.html
- +66 −40 documentation/docs/repl.html
- +12 −9 documentation/docs/rewriter.html
- +1 −1 documentation/docs/scope.html
- +31 −13 documentation/index.html.erb
- +1 −1 documentation/js/block_comment.js
- +1 −1 documentation/js/classes.js
- +2 −4 documentation/js/existence.js
- +1 −1 documentation/js/object_comprehensions.js
- +1 −1 documentation/js/while.js
- +0 −7 extras/EXTRAS
- +2 −2 extras/coffee-script.js
- +54 −40 index.html
- +60 −32 lib/coffee-script.js
- +39 −12 lib/command.js
- +11 −5 lib/lexer.js
- +123 −91 lib/nodes.js
- +63 −54 lib/repl.js
- +8 −4 lib/rewriter.js
- +1 −1 package.json
- +2 −2 src/browser.coffee
- +1 −1 src/cake.coffee
- +37 −24 src/coffee-script.coffee
- +23 −5 src/command.coffee
- +6 −5 src/grammar.coffee
- +12 −6 src/lexer.coffee
- +122 −78 src/nodes.coffee
- +1 −1 src/optparse.coffee
- +61 −35 src/repl.coffee
- +12 −9 src/rewriter.coffee
- +1 −1 src/scope.coffee
- +18 −0 test/assignment.coffee
- +14 −0 test/classes.coffee
- +5 −0 test/formatting.coffee
- +64 −1 test/function_invocation.coffee
- +14 −0 test/interpolation.coffee
- +4 −0 test/numbers.coffee
- +18 −0 test/objects.coffee
- +4 −0 test/operators.coffee
- +3 −0 test/ranges.coffee
- +12 −0 test/scope.coffee
| @@ -5,7 +5,7 @@ | ||
| Cakefile | ||
| documentation/ | ||
| examples/ | ||
| -extras/ | ||
| +extras/coffee-script.js | ||
| raw/ | ||
| src/ | ||
| test/ | ||
| @@ -28,10 +28,12 @@ sources = [ | ||
| ] | ||
| # Run a CoffeeScript through our node/coffee interpreter. | ||
| -run = (args) -> | ||
| +run = (args, cb) -> | ||
| proc = spawn 'bin/coffee', args | ||
| proc.stderr.on 'data', (buffer) -> console.log buffer.toString() | ||
| - proc.on 'exit', (status) -> process.exit(1) if status != 0 | ||
| + proc.on 'exit', (status) -> | ||
| + process.exit(1) if status != 0 | ||
| + cb() if typeof cb is 'function' | ||
| # Log a message with a color. | ||
| log = (message, color, explanation) -> | ||
| @@ -59,17 +61,16 @@ task 'install', 'install CoffeeScript into /usr/local (or --prefix)', (options) | ||
| ) | ||
| -task 'build', 'build the CoffeeScript language from source', -> | ||
| +task 'build', 'build the CoffeeScript language from source', build = (cb) -> | ||
| files = fs.readdirSync 'src' | ||
| files = ('src/' + file for file in files when file.match(/\.coffee$/)) | ||
| - run ['-c', '-o', 'lib'].concat(files) | ||
| + run ['-c', '-o', 'lib'].concat(files), cb | ||
| task 'build:full', 'rebuild the source twice, and run the tests', -> | ||
| - exec 'bin/cake build && bin/cake build && bin/cake test', (err, stdout, stderr) -> | ||
| - console.log stdout.trim() if stdout | ||
| - console.log stderr.trim() if stderr | ||
| - throw err if err | ||
| + build -> | ||
| + build -> | ||
| + process.exit 1 unless runTests CoffeeScript | ||
| task 'build:parser', 'rebuild the Jison parser (run build first)', -> | ||
| @@ -152,7 +153,7 @@ runTests = (CoffeeScript) -> | ||
| passedTests = 0 | ||
| failures = [] | ||
| - # make "global" reference available to tests | ||
| + # Make "global" reference available to tests | ||
| global.global = global | ||
| # Mix in the assert module globally, to make it available for tests. | ||
| @@ -175,7 +176,7 @@ runTests = (CoffeeScript) -> | ||
| catch e | ||
| e.description = description if description? | ||
| e.source = fn.toString() if fn.toString? | ||
| - failures.push file: currentFile, error: e | ||
| + failures.push filename: currentFile, error: e | ||
| # A recursive functional equivalence helper; uses egal for testing equivalence. | ||
| # See http://wiki.ecmascript.org/doku.php?id=harmony:egal | ||
| @@ -201,27 +202,28 @@ runTests = (CoffeeScript) -> | ||
| return log(message, green) unless failures.length | ||
| log "failed #{failures.length} and #{message}", red | ||
| for fail in failures | ||
| - {error, file} = fail | ||
| - jsFile = file.replace(/\.coffee$/,'.js') | ||
| + {error, filename} = fail | ||
| + jsFilename = filename.replace(/\.coffee$/,'.js') | ||
| match = error.stack?.match(new RegExp(fail.file+":(\\d+):(\\d+)")) | ||
| match = error.stack?.match(/on line (\d+):/) unless match | ||
| [match, line, col] = match if match | ||
| - log "\n #{error.toString()}", red | ||
| + console.log '' | ||
| log " #{error.description}", red if error.description | ||
| - log " #{jsFile}: line #{line or 'unknown'}, column #{col or 'unknown'}", red | ||
| + log " #{error.stack}", red | ||
| + log " #{jsFilename}: line #{line ? 'unknown'}, column #{col ? 'unknown'}", red | ||
| console.log " #{error.source}" if error.source | ||
| + return | ||
| # Run every test in the `test` folder, recording failures. | ||
| - fs.readdir 'test', (err, files) -> | ||
| - files.forEach (file) -> | ||
| - return unless file.match(/\.coffee$/i) | ||
| - filename = path.join 'test', file | ||
| - fs.readFile filename, (err, code) -> | ||
| - currentFile = filename | ||
| - try | ||
| - CoffeeScript.run code.toString(), {filename} | ||
| - catch e | ||
| - failures.push file: currentFile, error: e | ||
| + files = fs.readdirSync 'test' | ||
| + for file in files when file.match /\.coffee$/i | ||
| + currentFile = filename = path.join 'test', file | ||
| + code = fs.readFileSync filename | ||
| + try | ||
| + CoffeeScript.run code.toString(), {filename} | ||
| + catch error | ||
| + failures.push {filename, error} | ||
| + return !failures.length | ||
| task 'test', 'run the CoffeeScript language test suite', -> | ||
| @@ -8,4 +8,4 @@ if car.speed < limit then accelerate() | ||
| winner = yes if pick in [47, 92, 13] | ||
| -print inspect "My name is " + @name | ||
| +print inspect "My name is #{@name}" | ||
| @@ -1,5 +1,5 @@ | ||
| ### | ||
| -CoffeeScript Compiler v1.1.1 | ||
| +CoffeeScript Compiler v1.1.2 | ||
| Released under the MIT License | ||
| ### | ||
| @@ -2,7 +2,7 @@ class Animal | ||
| constructor: (@name) -> | ||
| move: (meters) -> | ||
| - alert @name + " moved " + meters + "m." | ||
| + alert @name + " moved #{meters}m." | ||
| class Snake extends Animal | ||
| move: -> | ||
| @@ -2,6 +2,6 @@ alert( | ||
| try | ||
| nonexistent / undefined | ||
| catch error | ||
| - "And the error is ... " + error | ||
| + "And the error is ... #{error}" | ||
| ) | ||
| @@ -1,4 +1,4 @@ | ||
| yearsOld = max: 10, ida: 9, tim: 11 | ||
| ages = for child, age of yearsOld | ||
| - child + " is " + age | ||
| + "#{child} is #{age}" |
| @@ -6,5 +6,5 @@ if this.studyingEconomics | ||
| # Nursery Rhyme | ||
| num = 6 | ||
| lyrics = while num -= 1 | ||
| - num + " little monkeys, jumping on the bed. | ||
| + "#{num} little monkeys, jumping on the bed. | ||
| One fell out and bumped his head." | ||
| @@ -85,6 +85,10 @@ code, pre, tt, textarea { | ||
| font-weight: normal; | ||
| color: black; | ||
| } | ||
| + .timestamp small { | ||
| + font-size: 11px; | ||
| + text-transform: uppercase; | ||
| + } | ||
| div.code { | ||
| position: relative; | ||
| background: #fff; | ||
| @@ -9,10 +9,10 @@ | ||
| <span class="nv">xhr.onreadystatechange = </span><span class="o">-></span> | ||
| <span class="k">if</span> <span class="nx">xhr</span><span class="p">.</span><span class="nx">readyState</span> <span class="o">is</span> <span class="mi">4</span> | ||
| <span class="k">if</span> <span class="nx">xhr</span><span class="p">.</span><span class="nx">status</span> <span class="k">in</span> <span class="p">[</span><span class="mi">0</span><span class="p">,</span> <span class="mi">200</span><span class="p">]</span> | ||
| - <span class="nx">CoffeeScript</span><span class="p">.</span><span class="nx">run</span> <span class="nx">xhr</span><span class="p">.</span><span class="nx">responseText</span> | ||
| + <span class="nx">CoffeeScript</span><span class="p">.</span><span class="nx">run</span> <span class="nx">xhr</span><span class="p">.</span><span class="nx">responseText</span> | ||
| <span class="k">else</span> | ||
| <span class="k">throw</span> <span class="k">new</span> <span class="nb">Error</span> <span class="s2">"Could not load #{url}"</span> | ||
| - <span class="nx">callback</span><span class="p">()</span> <span class="k">if</span> <span class="nx">callback</span> | ||
| + <span class="nx">callback</span><span class="p">()</span> <span class="k">if</span> <span class="nx">callback</span> | ||
| <span class="nx">xhr</span><span class="p">.</span><span class="nx">send</span> <span class="kc">null</span></pre></div> </td> </tr> <tr id="section-6"> <td class="docs"> <div class="pilwrap"> <a class="pilcrow" href="#section-6">¶</a> </div> <p>Activate CoffeeScript in the browser by having it compile and evaluate | ||
| all script tags with a content-type of <code>text/coffeescript</code>. | ||
| This happens on page load.</p> </td> <td class="code"> <div class="highlight"><pre><span class="nv">runScripts = </span><span class="o">-></span> | ||
| @@ -36,7 +36,7 @@ | ||
| <span class="nv">spaces = </span><span class="k">if</span> <span class="nx">spaces</span> <span class="o">></span> <span class="mi">0</span> <span class="k">then</span> <span class="nb">Array</span><span class="p">(</span><span class="nx">spaces</span> <span class="o">+</span> <span class="mi">1</span><span class="p">).</span><span class="nx">join</span><span class="p">(</span><span class="s1">' '</span><span class="p">)</span> <span class="k">else</span> <span class="s1">''</span> | ||
| <span class="nv">desc = </span><span class="k">if</span> <span class="nx">task</span><span class="p">.</span><span class="nx">description</span> <span class="k">then</span> <span class="s2">"# #{task.description}"</span> <span class="k">else</span> <span class="s1">''</span> | ||
| <span class="nx">console</span><span class="p">.</span><span class="nx">log</span> <span class="s2">"cake #{name}#{spaces} #{desc}"</span> | ||
| - <span class="nx">console</span><span class="p">.</span><span class="nx">log</span> <span class="nx">oparse</span><span class="p">.</span><span class="nx">help</span><span class="p">()</span> <span class="k">if</span> <span class="nx">switches</span><span class="p">.</span><span class="nx">length</span></pre></div> </td> </tr> <tr id="section-10"> <td class="docs"> <div class="pilwrap"> <a class="pilcrow" href="#section-10">¶</a> </div> <p>Print an error and exit when attempting to all an undefined task.</p> </td> <td class="code"> <div class="highlight"><pre><span class="nv">missingTask = </span><span class="p">(</span><span class="nx">task</span><span class="p">)</span> <span class="o">-></span> | ||
| + <span class="nx">console</span><span class="p">.</span><span class="nx">log</span> <span class="nx">oparse</span><span class="p">.</span><span class="nx">help</span><span class="p">()</span> <span class="k">if</span> <span class="nx">switches</span><span class="p">.</span><span class="nx">length</span></pre></div> </td> </tr> <tr id="section-10"> <td class="docs"> <div class="pilwrap"> <a class="pilcrow" href="#section-10">¶</a> </div> <p>Print an error and exit when attempting to call an undefined task.</p> </td> <td class="code"> <div class="highlight"><pre><span class="nv">missingTask = </span><span class="p">(</span><span class="nx">task</span><span class="p">)</span> <span class="o">-></span> | ||
| <span class="nx">console</span><span class="p">.</span><span class="nx">log</span> <span class="s2">"No such task: \"#{task}\""</span> | ||
| <span class="nx">process</span><span class="p">.</span><span class="nx">exit</span> <span class="mi">1</span> | ||
Showing you all comments on commits in this comparison.
|
Shouldn't this work as well? |
|
Thanks satyr. Fixed here: 9e32a5b |
|
Should probably accept this too: |
|
Why opting out |
|
Agreed. @jashkenas: are you going to address this? |
|
Dammit, pushed the wrong commit. This has a |
|
I wasn't planning on it -- abuse of |
|
@jashkenas: I almost always do consider I'd like to hear feedback from more CS users. Anyone have an opinion on this? |
|
Yes -- more feedback would be appreciated. My personal experience is that in all the places valueOf() is used in the wild -- which are few and far between -- all of the acceptable use cases are entirely side-effect-free. It's kind of built-in to the name of the function: if your valueOf() causes a side effect, that's a bug. |
|
Don't forget
I doubt normal users read commit comments. |
I believe all commit comments show up in the "news feed" of anyone that follows coffee-script, just like commits or newly-created issues. That would be over 2000 potential eyes. Can any non-collaborator confirm this? |
|
Confirming: I follow coffee-script, and can/do read commit comments. |
|
crap, commit message is supposed to say "fixed context" |
|
Uh .. what's up with the utility function? Can we leave this off master until we have an uncontroversial implementation of bind? |
|
That test case was broken. |
|
Alright, looks like nobody's responding. @jashkenas: @satyr: should I open an issue? I'm on the fence. |
|
|
|
Personally I no longer mind. Inconsistency can be a part of CoffeeScript philosophy I guess. |
|
Personally, I'm not worried about it. But if someone made a good use-case for a side-effect-ful valueOf, that actually appeared in real-world code, I'd change my mind. |
|
|
|
I considered that, but |
|
|
|
But if someone changes |
|
All three commits reverted on master -- if we want to explore alternative |
|
@jashkenas: so what do you suggest we do about the errant test case and broken bind function? You said we should use the native bind when it's available (which is pretty much always), but we can't do that if it has different behaviour than the one we provide. It wasn't that big of an addition. |
|
If this is compiling as an array, there should never be a step (SyntaxError). |
|
Fixed... er, changed: 8ce1fdb |
|
Hmm, I probably should have rebased right here. Sorry, commit history! |
|
|
|
Good catch, satyr. Michael, any particular reason for changing |
|
@TrevorBurnham: Yeah, |
|
Any chance of refactoring this so that all the |
|
Alright, both of the above mentioned issues should be fixed by b9c3e0e. Thanks for testing it out and looking it over. edit: Sure, I'll look into it right now. |
|
|
|
Uh wait, you're writing it back. Seems ok unless user does |
|
@TrevorBurnham: see 003f91d for the refactor you wanted and a much sweeter line continuation input/output. |
|
I don't know why it makes these commits when I |
|
Eh, better not to rebase anyway, if you don't have to. Rebase is just lying about what the true history really is. |
|
This feels inconsistent: If I pass |
|
It needs to be a |
|
Ah, interesting. Well, in that case, the only change I'd make here would be to move and I don't see any use case for sandboxed code having access to its global object through |
|
I don't agree. That change would prevent the user from providing a value for |
|
Well, why require either |
|
So do you think we should define update: gist |
|
Sure. But then I really want a way of getting the sandbox created by
One option would be to change the API to have multiple return values, but it's so nice to be able to write I think the best alternative is to set something like |
|
Actually, here's a more elegant suggestion: Keep the current API of Then the REPL's If you like, I can implement this and make a pull request. |
|
Do we really need
|
|
Yeah, I'd say that it's pretty important for |
|
@satyr: I don't think removing |
|
@TrevorBurnham: I don't think having an |
Reasons? FYI, it's added exclusively for REPL (c49cd02). |
|
@michaelficarra Right, but it provides another method that folks can use for that purpose (and which we can use for the REPL), while keeping the current behavior of |
That's the only place it is used internally, but we provide it in our public API so that our users have access to it. It's the same reason we have |
While |
|
There's still significant funkiness here @jashkenas, so you may want to be careful when you push this to the pages branch. I'll try and figure out what made this happen on my box. |
|
Thanks for telling me. I've regenerated the index.html page here: In the future, there's never any need to build any of the auto-generated pages when submitting pull requests -- they only tend to cause merge trouble later on. Building the docs is best done when releases are tagged and pushed. |
|
Thanks and noted. That'll be easier :) |
|
I tried a |
|
Looking back through the history of $ coffee -bep '=>'
var __bind = (Function.prototype.bind ? Function.prototype.call.bind(Function.prototype.bind) : function(fn, me){
var ctor = function(){};
ctor.prototype = fn.prototype;
return function bound(){
if (!(this instanceof bound))
return fn.apply(me, arguments);
var obj = new ctor;
fn.apply(obj, arguments);
return obj;
};
});
__bind(function() {}, this);
Still, the changelog lies and should probably be corrected. |
|
Whoops -- I saw a commit for it in the history, but it must've been on a branch. Fixing the changelog now. |
|
Yep, that was the |
1fb34e4 reverted it. |
|
Nice work, fellow Kentuckian! This was a well-needed optimization - very pleased someone pursued this. When I contributed my changes to fix directory traversal in join mode (371ff5e), the extra compileJoin() calls had irked me as well, but I couldn't think of an elegant way to eliminate them at the time. However, while your change was working great for me initially, the compiler began to fail silently after I committed the directories containing my .coffee files to SVN. See issue #1624 for more details why, including my patch (0bf0f6d) to resolve this. |