| *** Joins: michaelarestad ([email protected]:282:100:71f0:3c47:877c:1aa0:d435) | 00:30 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:3c47:877c:1aa0:d435) (Ping timeout: 248 seconds) | 00:35 | |
| *** Quits: milesj ([email protected]) (Quit: Sleeping...) | 00:40 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:3c47:877c:1aa0:d435) | 01:31 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:3c47:877c:1aa0:d435) (Ping timeout: 248 seconds) | 01:36 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) | 03:52 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) (Ping timeout: 256 seconds) | 03:59 | |
| *** Joins: sfrisk ([email protected]) | 04:55 | |
| *** Quits: sfrisk ([email protected]) (Remote host closed the connection) | 05:14 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) | 05:55 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) (Ping timeout: 248 seconds) | 06:01 | |
| *** Joins: sfrisk ([email protected]) | 06:02 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) | 06:57 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) (Ping timeout: 248 seconds) | 07:02 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) | 07:43 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) (Ping timeout: 248 seconds) | 07:48 | |
| *** Quits: sfrisk ([email protected]) () | 07:55 | |
| *** Joins: sfrisk ([email protected]) | 07:57 | |
| *** Joins: sfrisk_ ([email protected]) | 08:14 | |
| *** Quits: sfrisk_ ([email protected]) (Read error: Connection reset by peer) | 08:15 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) | 08:25 | |
| *** Quits: sfrisk ([email protected]) (Remote host closed the connection) | 08:35 | |
| *** Joins: geekman-rohit ([email protected]) | 08:54 | |
| *** Joins: sfrisk ([email protected]) | 08:55 | |
| sfrisk | geekman-rohit, arschmitz, arthurvr --- fun party gsoc time! | 09:01 |
|---|---|---|
| arthurvr | hey | 09:01 |
| geekman-rohit | hey | 09:01 |
| sfrisk | hope everyone is doing well today | 09:01 |
| geekman-rohit | arthurvr our main agenda today is your suggestions on the PR :) | 09:02 |
| arthurvr | alright :p | 09:02 |
| sfrisk | Figured it was best to bring some of the stuff you were talking about | 09:02 |
| sfrisk | up here | 09:02 |
| geekman-rohit | https://github.com/jquery/themeroller.css-chassis.com/pull/8#discussion_r34021124 | 09:02 |
| sfrisk | also, on that note, jzaefferer, if you want input on this conversation, we're discussing gsoc themeroller stuff | 09:02 |
| geekman-rohit | ping arschmitz | 09:04 |
| arthurvr | geekman-rohit: what’s up with that comment? | 09:05 |
| geekman-rohit | umm comment ? | 09:06 |
| sfrisk | I think geekman was referring to the whole PR | 09:06 |
| arthurvr | well you linked up one comment (notice the url) :p | 09:06 |
| geekman-rohit | yep, the whole PR, basically should we test on nodejs 0.12 too on travis | 09:07 |
| jzaefferer | oh hai | 09:07 |
| geekman-rohit | I mean especially that point | 09:07 |
| geekman-rohit | hey! | 09:07 |
| arthurvr | well I don’t see why not we might as well be future-proof | 09:07 |
| sfrisk | I know there are reasons why we haven't switched from nodejs 0.10 | 09:07 |
| jzaefferer | are there? | 09:08 |
| sfrisk | I thought there were | 09:08 |
| arthurvr | I think the reason was just it works so why bother changing it | 09:08 |
| sfrisk | I seem to recall a discussion about it when someone suggested moving chassis to 12 | 09:08 |
| sfrisk | let me see if I can find the discussion | 09:08 |
| sfrisk | I remember it got grumpy | 09:08 |
| arthurvr | oh I do remember | 09:09 |
| arthurvr | because libsass didn’t use to support 0.12 | 09:09 |
| arthurvr | IIRC that was the reason | 09:09 |
| sfrisk | ahhh | 09:09 |
| sfrisk | that sounds right | 09:09 |
| arthurvr | which doesn’t matter for themeroller | 09:10 |
| geekman-rohit | umm it does actually | 09:10 |
| arthurvr | why? libsass is fixed these days? | 09:10 |
| geekman-rohit | does it already support 0.12 ? | 09:10 |
| sfrisk | Checking now | 09:10 |
| arthurvr | I don’t know what version chassis is on but the latest libsass supports it | 09:10 |
| sfrisk | I remember arschmitz was the one who did a lot of that initial configuration | 09:12 |
| arschmitz | hey sorry | 09:12 |
| geekman-rohit | and themeroller will depend on chassis | 09:12 |
| geekman-rohit | in future, if I am not wrong | 09:12 |
| geekman-rohit | so what version of node chassis supports also matters | 09:13 |
| arthurvr | we just need to bump grunt-sass in the chassis repo | 09:14 |
| arthurvr | to ^1.0.0 | 09:14 |
| arschmitz | so chassis it self should support as much as we can | 09:14 |
| arschmitz | as far as node versions | 09:14 |
| arthurvr | https://github.com/sindresorhus/grunt-sass/releases/tag/v1.0.0 | 09:14 |
| arschmitz | within reason | 09:14 |
| arschmitz | so it should be tested on both .10 and .12 | 09:14 |
| arthurvr | yeah sure it should | 09:14 |
| sfrisk | when is the plan to switch stuff to .12? | 09:15 |
| arschmitz | there is not one currently | 09:15 |
| arthurvr | as quick as possible I’d say | 09:15 |
| arschmitz | Bumping the node version on all the servers requires a lot of testing | 09:15 |
| geekman-rohit | themeroller straight away I guess, I need that PR to land soon so Im gonna update it straightaway | 09:15 |
| arschmitz | thats its not likely anyone has time to deal with right now | 09:16 |
| jzaefferer | why do all severs have to run the same node version? | 09:16 |
| jzaefferer | *servers | 09:16 |
| arschmitz | they dont but we do to make it easier to manage | 09:16 |
| geekman-rohit | exactly my query | 09:16 |
| arschmitz | because stuff gets moved around | 09:16 |
| jzaefferer | Even so, we should run CI with both 0.10 and 0.12 | 09:16 |
| arschmitz | jzaefferer: yes we should | 09:16 |
| arthurvr | sure | 09:16 |
| geekman-rohit | sure | 09:16 |
| geekman-rohit | my only concern was since we will depend on chassis too | 09:17 |
| geekman-rohit | what chassis supports will also matter | 09:17 |
| arthurvr | we should just open an issue to bump all chassis deps | 09:17 |
| arschmitz | geekman-rohit: chassis should be testing and supporting both | 09:17 |
| arschmitz | it just has not been updated i dont think .12 was even out when i set this repo up | 09:17 |
| geekman-rohit | nice | 09:17 |
| sfrisk | I can create an issue to bump dependencies | 09:17 |
| arthurvr | :+1: | 09:18 |
| geekman-rohit | thats cool :) | 09:18 |
| arthurvr | next up? | 09:18 |
| geekman-rohit | and Ill update the PR | 09:18 |
| geekman-rohit | container based infra. I agree, I didnt know about it | 09:18 |
| geekman-rohit | on your suggestion I read and agree | 09:18 |
| arthurvr | yeah I don’t think there’s much doubt about that | 09:19 |
| arschmitz | because we are talking about having chassis have its own node api its really really important we support different versions | 09:19 |
| geekman-rohit | arschmitz +1 | 09:19 |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) (Remote host closed the connection) | 09:19 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) | 09:20 | |
| *** Joins: chassis-commit ([email protected]) | 09:21 | |
| chassis-commit | [css-chassis] sfrisk opened issue #95: Update Chassis to support node 0.12 http://git.io/vqERj | 09:21 |
| *** Parts: chassis-commit ([email protected]) () | 09:21 | |
| geekman-rohit | jscs startup, well I missed that, and I think I should remove it from both since the folder doesnt exist as of now | 09:22 |
| geekman-rohit | we will add as we go | 09:22 |
| arthurvr | Why are we spending time going over almost every review comment? Most of them don’t really need much discussion :p | 09:23 |
| geekman-rohit | yep, we are not going to, only ones I though need to be discussed | 09:23 |
| geekman-rohit | and only one left is jscs quotemark : double | 09:24 |
| sfrisk | I think that was more of a discussion for contribute and the style guides there? | 09:25 |
| geekman-rohit | yes so I'll let it be as it is till then | 09:26 |
| arthurvr | sfrisk: not really as the styleguide doesn’t talk about JSCS. | 09:27 |
| sfrisk | true | 09:27 |
| arschmitz | i think we should leave it in the jshint | 09:27 |
| arthurvr | why? | 09:27 |
| sfrisk | but the quotemark: double is in the linting guide for jshintrc | 09:27 |
| arschmitz | since we say we follow the styleguie and the style guide lists that rule | 09:27 |
| arschmitz | and it does not hurt to do it twice | 09:28 |
| sfrisk | https://contribute.jquery.org/style-guide/js/ | 09:28 |
| arthurvr | sfrisk: well if you don’t use JSCS that makes sense, but we do :p | 09:28 |
| arthurvr | it’s not big deal, but we’re checking that and some other things twice now | 09:28 |
| arthurvr | JSHint is slow enough :p | 09:28 |
| arschmitz | arthurvr: i highly doubt that one rule will make a noticeable difference | 09:28 |
| arthurvr | arschmitz: Dunno, as I said it’s no big. leave it at this for now then | 09:29 |
| geekman-rohit | cool then :) arthurvr I brought the comments up merely to take arschmitzs inputs on it | 09:30 |
| geekman-rohit | I think that solves my concerns :) I'll update the PR in some time | 09:30 |
| arthurvr | https://github.com/jquery/themeroller.css-chassis.com/pull/8#discussion_r34020987 | 09:30 |
| arthurvr | do we really need the overhead of load-grunt-config? | 09:30 |
| arthurvr | I mean our gruntfile is 30 lines :p | 09:31 |
| arschmitz | arthurvr: i expect it will grow considderibly | 09:31 |
| geekman-rohit | what arschmitz said, yes | 09:31 |
| arschmitz | geekman-rohit: i would leave it up to you to use for the case knowing how you plan to structure thing | 09:31 |
| arthurvr | Even if it grows I don’t see a problem with it being big :p | 09:32 |
| arschmitz | but if you expect it to get very big i think its worth using load-grunt-config | 09:32 |
| arthurvr | define ”big” | 09:32 |
| sfrisk | We can always change it in the future | 09:32 |
| geekman-rohit | yep and I need that PR merged as soon as possible | 09:32 |
| geekman-rohit | so I agree with sfrsik | 09:32 |
| geekman-rohit | sfrisk* | 09:32 |
| sfrisk | haha, arschmitz has the power too :-p | 09:32 |
| geekman-rohit | no I mean I will have to read about it, so better later | 09:33 |
| arschmitz | geekman-rohit: i think you should use one or the other but i would leave it up to you what you think is best | 09:33 |
| geekman-rohit | so we dont keep the PR waiting | 09:33 |
| geekman-rohit | arschmitz, if its okay I would like to read about it and make the change later, once this merges, I have 2 more PRs to start | 09:33 |
| sfrisk | well if everyone is happy with the PR, I can pull it in, probably this afternoon - this computer hasn't been set up with jQuery projects yet | 09:33 |
| arthurvr | well those few things I commented and for the rest a big :+1: of mine | 09:34 |
| geekman-rohit | another thing, arshcmitz about adding files to jscs / css lint | 09:35 |
| geekman-rohit | will **.js / **.css work for us? | 09:35 |
| arschmitz | no you need to exclude external things | 09:36 |
| geekman-rohit | I think it would check 3rd party files too? | 09:36 |
| arschmitz | yes | 09:37 |
| arschmitz | see my comment i just put | 09:37 |
| geekman-rohit | so we just add our folders, the way I plan it there should be 3 paths needed, I add them now or as we go | 09:37 |
| geekman-rohit | yep | 09:38 |
| geekman-rohit | that was all on my list, except yeah, do we need to setup checking CLA? | 09:38 |
| geekman-rohit | I remember all jquery projects do that | 09:38 |
| arschmitz | geekman-rohit: yes thats done with github settings though | 09:39 |
| arschmitz | im guessing it has to be done by scott_gonzalez | 09:39 |
| geekman-rohit | oh cool | 09:39 |
| geekman-rohit | that is all, unless there is anything anyone thinks I missed? | 09:40 |
| sfrisk | I don't think so | 09:41 |
| sfrisk | Can anyone else think of anything? | 09:41 |
| scott_gonzalez | arschmitz geekman-rohit: Is the CLA check not running? | 09:43 |
| scott_gonzalez | I see tags on all the PRs. | 09:43 |
| arthurvr | scott_gonzalez: I don’t see any labels | 09:43 |
| scott_gonzalez | Oh, is this for the download builder repo? | 09:43 |
| arschmitz | scott_gonzalez: themeroller.css-chassis.com | 09:43 |
| geekman-rohit | scott_gonzalez, for themeroller.css-chassis.com | 09:44 |
| arschmitz | scott_gonzalez: https://github.com/jquery/themeroller.css-chassis.com/pulls | 09:44 |
| scott_gonzalez | Ah, one sec, I'll add it. | 09:44 |
| scott_gonzalez | For future reference, it's just a web hook, so anyone with admin on the repo can set it up. | 09:44 |
| sfrisk | Okay, awesome, thanks | 09:44 |
| geekman-rohit | great! thanks | 09:44 |
| scott_gonzalez | geekman-rohit: If you push an updated to PR #6, we can see if it's working now. | 09:46 |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) (Remote host closed the connection) | 09:47 | |
| geekman-rohit | i'll be doing that in like an hour? | 09:47 |
| geekman-rohit | I'll ping you if it doesnt work, scott_gonzalez | 09:47 |
| scott_gonzalez | ok | 09:47 |
| geekman-rohit | cool :) thanks | 09:47 |
| geekman-rohit | thanks for your time everyone :) | 09:50 |
| sfrisk | no problem | 09:50 |
| *** Quits: geekman-rohit ([email protected]) (Quit: Leaving) | 09:56 | |
| *** Joins: kristyjy ([email protected]) | 09:58 | |
| *** Joins: milesj ([email protected]) | 10:00 | |
| *** Joins: geekman-rohit ([email protected]) | 10:02 | |
| sfrisk | Meeting time in #jquery-meeting everyone! | 10:03 |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) | 10:15 | |
| *** Quits: kristyjy ([email protected]) () | 10:44 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) (Remote host closed the connection) | 11:03 | |
| *** Joins: michaelarestad ([email protected]) | 11:07 | |
| *** Quits: michaelarestad ([email protected]) (Remote host closed the connection) | 11:10 | |
| *** Joins: michaelarestad ([email protected]) | 11:10 | |
| *** Quits: sfrisk ([email protected]) (Remote host closed the connection) | 11:12 | |
| *** Quits: michaelarestad ([email protected]) (Remote host closed the connection) | 11:22 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) | 11:24 | |
| *** Joins: sfrisk ([email protected]) | 11:27 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) (Ping timeout: 248 seconds) | 11:29 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) | 11:37 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:64:d97e:8c41:9f9c) (Ping timeout: 248 seconds) | 11:42 | |
| *** Quits: geekman-rohit ([email protected]) (Quit: Leaving) | 11:53 | |
| *** Joins: michaelarestad ([email protected]) | 12:24 | |
| *** Quits: michaelarestad ([email protected]) (Remote host closed the connection) | 12:29 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:2cac:a4ce:a73c:4096) | 12:30 | |
| *** Joins: geekman-rohit ([email protected]) | 12:41 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:2cac:a4ce:a73c:4096) (Remote host closed the connection) | 12:48 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:2cac:a4ce:a73c:4096) | 12:52 | |
| *** Quits: milesj ([email protected]) (Quit: Sleeping...) | 12:55 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:2cac:a4ce:a73c:4096) (Remote host closed the connection) | 13:05 | |
| *** Joins: michaelarestad ([email protected]) | 13:10 | |
| *** Quits: geekman-rohit ([email protected]) (Read error: Connection reset by peer) | 13:14 | |
| *** Joins: milesj ([email protected]) | 13:14 | |
| *** Joins: geekman-rohit ([email protected]) | 13:14 | |
| *** Quits: michaelarestad ([email protected]) (Remote host closed the connection) | 13:36 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:2cac:a4ce:a73c:4096) | 13:38 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:2cac:a4ce:a73c:4096) (Remote host closed the connection) | 13:39 | |
| *** Joins: michaelarestad ([email protected]) | 13:47 | |
| *** Joins: abec ([email protected]) | 13:53 | |
| *** Parts: abec ([email protected]) () | 13:54 | |
| *** Quits: geekman-rohit ([email protected]) (Ping timeout: 244 seconds) | 14:05 | |
| *** Joins: abck ([email protected]/beckmann/x-2709655) | 14:13 | |
| *** Quits: abck ([email protected]/beckmann/x-2709655) (Quit: PZL8) | 14:22 | |
| *** Joins: abck ([email protected]) | 14:38 | |
| *** Quits: abck ([email protected]) (Client Quit) | 14:38 | |
| *** Joins: abck ([email protected]) | 14:40 | |
| *** Quits: abck ([email protected]) (Changing host) | 14:40 | |
| *** Joins: abck ([email protected]/beckmann/x-2709655) | 14:40 | |
| *** Quits: abck ([email protected]/beckmann/x-2709655) (Max SendQ exceeded) | 14:41 | |
| *** Quits: sfrisk ([email protected]) (Remote host closed the connection) | 14:50 | |
| *** Joins: abck ([email protected]/abck) | 15:05 | |
| *** Joins: sfrisk ([email protected]) | 15:16 | |
| *** Joins: sfrisk_ ([email protected]) | 16:16 | |
| *** Quits: sfrisk ([email protected]) (Read error: Connection reset by peer) | 16:16 | |
| *** Quits: abck ([email protected]/abck) (Quit: PZL8) | 16:22 | |
| *** Quits: milesj ([email protected]) (Quit: Sleeping...) | 16:24 | |
| *** Joins: abck ([email protected]/abck) | 17:02 | |
| *** Parts: abck ([email protected]/abck) ("PZL8") | 17:36 | |
| *** Quits: michaelarestad ([email protected]) (Ping timeout: 276 seconds) | 18:22 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:2cac:a4ce:a73c:4096) | 18:28 | |
| *** Quits: sfrisk_ ([email protected]) (Remote host closed the connection) | 18:45 | |
| *** Joins: sfrisk ([email protected]) | 18:46 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:2cac:a4ce:a73c:4096) (Ping timeout: 248 seconds) | 19:38 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:2cac:a4ce:a73c:4096) | 19:45 | |
| *** Quits: sfrisk ([email protected]) (Remote host closed the connection) | 20:12 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:2cac:a4ce:a73c:4096) (Ping timeout: 248 seconds) | 21:47 | |
| *** Joins: michaelarestad ([email protected]:282:100:71f0:2cac:a4ce:a73c:4096) | 21:48 | |
| *** Quits: michaelarestad ([email protected]:282:100:71f0:2cac:a4ce:a73c:4096) (Ping timeout: 240 seconds) | 23:18 | |
| *** Joins: milesj ([email protected]) | 23:25 | |
| *** Joins: michaelarestad ([email protected]) | 23:27 | |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!