Selectmenu: Calling refresh() after removing all options throws an error

[janom]

after remove all options from select and then call refresh on selectmenu, i get error: "this.menuItems is undefined" ​http://jsfiddle.net/janom/w0q994gu/

[janom]

I changed selectmenu javascript... can you please check if my solutions is right? in _refreshMenu: function() i change from this lines:

		if ( !options.length ) {
			return;
		}

		this._parseOptions( options );
		this._renderMenu( this.menu, this.items );

		this.menuInstance.refresh();
		this.menuItems = this.menu.find( "li" ).not( ".ui-selectmenu-optgroup" );

to this lines:

		this._parseOptions( options );
		this._renderMenu( this.menu, this.items );

		this.menuItems = this.menu.find( "li" ).not( ".ui-selectmenu-optgroup" );

		if ( !options.length ) {
			return;
		}

		this.menuInstance.refresh();

and in open: function( event ) i change this line:

		if ( !this.menuItems ) {

to this line:

		if ( !this.menuItems || this.menuItems.length==0) {

[tj.vantoll]

If you're interested in submitting a patch please do so as a ​pull request.

[janom]

​https://github.com/jquery/jquery-ui/pull/1370

[Scott González]

Selectmenu: Better handling when there are no options

Fixes #10662 Closes gh-1370 Closes gh-1423

Changeset: 65584c1640f8c7430587738c3c4cd7dd8010a2a5

[scottgonzalez]

#12262 is a duplicate of this ticket.

[alexandis]

Excuse me, I'm experiencing the same problem on jquery UI 1.11.4 now, downloaded from official link. How come that the code there is old - not the one that is present in the ​fix? I've tried to replace piece of code, related to selectmenu, from selectmenu.js from github. But then getting exception here: var item = ui.item.data("ui-selectmenu-item"); in focus event, since ui.item is empty object...

[scottgonzalez]

The milestone on this ticket is 1.12.0, which means that the fix wouldn't be included in 1.11.4.

[alexandis]

Replying to scottgonzalez:

The milestone on this ticket is 1.12.0, which means that the fix wouldn't be included in 1.11.4.

Ok. Then how should i fix the issue with refreshing after removing options? Thanks.

[scottgonzalez]

Upgrade to the latest pre-release of 1.12.0.

[alexandis]

Replying to scottgonzalez:

Upgrade to the latest pre-release of 1.12.0.

Thank you. I've replaced 1.11.4 with 1.12 release candidate, but now I got exception when trying to create dialog object (where 1.11.4 worked properly): effectMethod is undefined (effectMethod = $.effects.effect[ args.effect ], args.effect is true, not some effect name). Unfortunately, it's not possible to send call stack from Firebug...

[scottgonzalez]

Please create a new ticket as this is unrelated. Thanks.