Issue 2041193003: Remove AppCache intercepts on insecure, online pages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2041193003: Remove AppCache intercepts on insecure, online pages

Can't Edit
Can't Publish+Mail
Start Review

Created:
1 year ago by jww

Modified:
12 months ago

Reviewers:
michaeln

CC:
chromium-reviews, darin-cc_chromium.org, blink-reviews, jam (ooo 6-14 - 6-20)

Base URL:
https://chromium.googlesource.com/chromium/src@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove AppCache intercepts on insecure, online pages BUG=588931

Patch Set 1 #

Created: 1 year ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -0 lines)			Patch
M	content/browser/appcache/appcache_interceptor.cc	View	7 chunks	+31 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/appcache-online.html	View	1 chunk	+60 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/resources/appcache-online.manifest	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Trybot results: Sign in to try more bots

Commit queue not available (can’t edit this change).

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jww

michaeln@, this is the first-take CL I mentioned in the email. Can you sanity check ...

1 year ago (2016-06-07 01:22:59 UTC) #2

michaeln

On 2016/06/07 01:22:59, jww wrote: > michaeln@, this is the first-take CL I mentioned in ...

12 months ago (2016-06-14 18:06:03 UTC) #3

jww

12 months ago (2016-06-14 20:13:28 UTC) #4

On 2016/06/14 18:06:03, michaeln wrote:
> On 2016/06/07 01:22:59, jww wrote:
> > michaeln@, this is the first-take CL I mentioned in the email. Can you
sanity
> > check the approach so far?
> 
> Let's you, me, josh, and rbyers figure out how to go about this offline in
> email/meetings. Then come back to CLs.

Sounds good, and thanks for the rapid feedback!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages