Comment 1 Mounir Lamouri (:mounir) 2012-03-28 15:59:16 PDT

Created attachment 610336 [details] [diff] [review]
Part 2 - Basic security model

Basically, regular content will have to be fullscreen and chrome can do whatever they want.

Comment 2 Mounir Lamouri (:mounir) 2012-03-28 15:59:43 PDT

Created attachment 610337 [details] [diff] [review]
Part 3 - Revert orientation when fullscreen is left

Comment 3 Olli Pettay [:smaug] (pto-ish May 4 - May 8) 2012-03-28 17:58:47 PDT

Comment on attachment 610336 [details] [diff] [review]
Part 2 - Basic security model

Use GetOwner(), no mOwner

Comment 4 Olli Pettay [:smaug] (pto-ish May 4 - May 8) 2012-03-28 18:11:58 PDT

Comment on attachment 610337 [details] [diff] [review]
Part 3 - Revert orientation when fullscreen is left

Please no raw pointers which you don't clear ever.

Comment 5 Mounir Lamouri (:mounir) 2012-03-28 21:07:32 PDT

Created attachment 610415 [details] [diff] [review]
Part 1 - HAL/DOM boilerplate

Comment 6 Mounir Lamouri (:mounir) 2012-03-28 21:08:04 PDT

Created attachment 610416 [details] [diff] [review]
Part 2 - Basic security model

Comment 7 Mounir Lamouri (:mounir) 2012-03-28 21:08:31 PDT

Created attachment 610418 [details] [diff] [review]
Part 3 - Revert orientation when fullscreen is left

Comment 8 Olli Pettay [:smaug] (pto-ish May 4 - May 8) 2012-03-29 08:53:54 PDT

Comment on attachment 610416 [details] [diff] [review]
Part 2 - Basic security model


>-nsScreen::Create(nsPIDOMWindow* aWindow)
>+nsScreen::Create(nsGlobalWindow* aWindow)
Is there now any need for this change?



> {
>+  if (!aWindow) {
>+    return nsnull;
>+  }
MOZ_ASSERT that aWindow is not null


>+  nsCOMPtr<nsIDOMWindow> window = do_QueryInterface(GetOwner());
GetOwner returns nsPIDOMWindow which is-a nsIDOMWindow, so there shouldn't be
need for this QI
;
> }
> 
>+
> NS_IMETHODIMP
Extra newline before NS_IMETHODIMP

Comment 9 Olli Pettay [:smaug] (pto-ish May 4 - May 8) 2012-03-29 08:57:47 PDT

Comment on attachment 610418 [details] [diff] [review]
Part 3 - Revert orientation when fullscreen is left


>+  private:
>+    nsIDOMEventTarget* mTarget;

Just use event->GetCurrentTarget();

Comment 10 Mounir Lamouri (:mounir) 2012-03-30 09:38:50 PDT

https://hg.mozilla.org/mozilla-central/rev/a1ba687fd66a
https://hg.mozilla.org/mozilla-central/rev/d8aa32fa5531
https://hg.mozilla.org/mozilla-central/rev/13bf530d772d

Comment 11 Jean-Yves Perrier [:teoli] 2013-08-15 13:52:43 PDT

This has been documented, some time ago ;-)